apis/v1beta1: Host header must not be modified #2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds clarification to the spec to go along with existing conformance test from kubernetes-sigs#1980. Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/XS
shaneutt
approved these changes
Jun 5, 2023
k8s-ci-robot
added
the
approved
howardjohn
approved these changes
Jun 5, 2023
arkodg
reviewed
Jun 5, 2023
| @@ -59,7 +59,8 @@ type HTTPRouteSpec struct { | |||
| // Hostnames defines a set of hostname that should match against the HTTP Host | |||
| // header to select a HTTPRoute used to process the request. Implementations | |||
| // MUST ignore any port value specified in the HTTP Host header while | |||
| // performing a match. | |||
There was a problem hiding this comment.
suggest
// MUST ignore any port value specified in the HTTP Host header while
// performing a match, without modifying it.
|
Thanks @sunjayBhatia, great clarification. I think with the added text, @arkodg's comment is handled as well. I'll lgtm and hold to see if anyone has anything else. /lgtm |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
Thanks @sunjayBhatia! /approve |
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: howardjohn, robscott, shaneutt, sunjayBhatia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Adds clarification to the spec to go along with existing conformance test from #1980.
Which issue(s) this PR fixes:
Fixes #2091
Does this PR introduce a user-facing change?: