-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document root CRD objects as API resource types. #207
Conversation
Hi @jpeach. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When finding the set of root CRD types, the documentation generator checks for the `+genclient` annotation, ratherd than the newer `+kubebuilder:object:root`. Adding `+genclient` makes the root CRD type objects appear in the resource list at the head of the API documentation, which improves their visibility. Signed-off-by: James Peach <jpeach@vmware.com>
@robscott Can you PTAL at your leisure? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, jpeach The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When finding the set of root CRD types, the documentation
generator checks for the
+genclient
annotation, ratherdthan the newer
+kubebuilder:object:root
.Adding
+genclient
makes the root CRD type objects appear in theresource list at the head of the API documentation, which improves
their visibility.
Signed-off-by: James Peach jpeach@vmware.com