Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating storage and served versions for beta resources #2069

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Updating storage and served versions for beta resources #2069

merged 1 commit into from
Jun 5, 2023

Conversation

robscott
Copy link
Member

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR makes the following changes:

  • v1alpha2 of Gateway, GatewayClass, and HTTPRoute is no longer served
  • v1alpha2 of ReferenceGrant is deprecrated
  • v1beta1 is now the storage version for ReferenceGrant

The following guidance applies:

  • Users and implementations that were reading or writing from v1alpha2 of Gateway, GatewayClass, or HTTPRoute MUST upgrade to use v1beta1.
  • Users and implementations that were reading or writing from v1alpha2 of ReferenceGrant SHOULD upgrade to use v1beta1.

Does this PR introduce a user-facing change?:

Changes:
* v1alpha2 of Gateway, GatewayClass, and HTTPRoute is no longer served
* v1alpha2 of ReferenceGrant is deprecrated
* v1beta1 is now the storage version for ReferenceGrant

Guidance:
* Users and implementations that were reading or writing from v1alpha2 of Gateway, GatewayClass, or HTTPRoute MUST upgrade to use v1beta1.
* Users and implementations that were reading or writing from v1alpha2 of ReferenceGrant SHOULD upgrade to use v1beta1.

@robscott
Updating storage and served versions for beta resources
683494a 
* v1alpha2 of Gateway, GatewayClass, and HTTPRoute is no longer served
* v1alpha2 of ReferenceGrant is deprecrated
* v1beta1 is now the storage version for ReferenceGrant
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 26, 2023
@k8s-ci-robot k8s-ci-robot requested a review from bowei May 26, 2023 20:27
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 26, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2023
@robscott
Copy link
Member Author

This is a big change, adding a hold until we have consensus and broad awareness.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2023
@robscott robscott added this to the v0.8.0 milestone May 26, 2023
@robscott robscott added the release-blocker MUST be completed to complete the milestone label May 26, 2023
shaneutt
shaneutt approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/hold
/cc @arkodg @sunjayBhatia @skriss @Xunzhuo @mlavacca @michaelbeaumont @howardjohn

sunjayBhatia
sunjayBhatia approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contour is up to date with v1beta1

@shaneutt shaneutt requested a review from dprotaso May 30, 2023 15:58
michaelbeaumont
michaelbeaumont approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we're only supporting v1beta1

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkodg, michaelbeaumont, mlavacca, robscott, shaneutt, sunjayBhatia, Xunzhuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Contributor

dprotaso commented Jun 1, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2023
@robscott
Copy link
Member Author

robscott commented Jun 5, 2023

Thanks everyone!

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit c2d863b into kubernetes-sigs:main Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@shaneutt shaneutt shaneutt approved these changes

@sunjayBhatia sunjayBhatia sunjayBhatia approved these changes

@arkodg arkodg arkodg approved these changes

@mlavacca mlavacca mlavacca approved these changes

@Xunzhuo Xunzhuo Xunzhuo approved these changes

@bowei bowei Awaiting requested review from bowei

@youngnick youngnick Awaiting requested review from youngnick

@howardjohn howardjohn Awaiting requested review from howardjohn

@skriss skriss Awaiting requested review from skriss

@dprotaso dprotaso Awaiting requested review from dprotaso

Assignees

@dprotaso dprotaso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-blocker MUST be completed to complete the milestone release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
No open projects
Gateway API: The Road to GA
Status: Done
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.
9 participants
@robscott @k8s-ci-robot @dprotaso @michaelbeaumont @shaneutt @sunjayBhatia @arkodg @mlavacca @Xunzhuo