Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

define core protocol/port combinations #2065

Merged
merged 4 commits into from
May 26, 2023
Merged

define core protocol/port combinations #2065

merged 4 commits into from
May 26, 2023

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented May 25, 2023 •
edited
Loading

Part of #1842

Unblocks - #1859

Release Note

Define Core supported Listener Port and Protocol Combinations.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 25, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 25, 2023
@dprotaso dprotaso mentioned this pull request May 25, 2023
Closed
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 25, 2023
@robscott
Copy link
Member

Thanks @dprotaso! This probably needs codegen + a release note but otherwise LGTM. Will add a hold for consensus on this.

/hold
/cc @arkodg @howardjohn @sunjayBhatia @mlavacca @shaneutt @youngnick

@k8s-ci-robot k8s-ci-robot requested a review from arkodg May 25, 2023 21:26
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2023
@robscott robscott added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 26, 2023
@robscott
Copy link
Member

Thanks @dprotaso!

/hold cancel
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2023
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkodg, dprotaso, mlavacca, robscott, sunjayBhatia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7c7c0b3 into kubernetes-sigs:main May 26, 2023
@dprotaso dprotaso deleted the listener-core-combinations branch May 26, 2023 17:44
@dprotaso dprotaso mentioned this pull request May 26, 2023
Closed
@shaneutt shaneutt mentioned this pull request Jul 24, 2023
Closed
@shaneutt shaneutt mentioned this pull request Aug 7, 2023
Closed
@shaneutt shaneutt mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunjayBhatia sunjayBhatia sunjayBhatia approved these changes

@arkodg arkodg arkodg approved these changes

@mlavacca mlavacca mlavacca approved these changes

@robscott robscott Awaiting requested review from robscott

@shaneutt shaneutt Awaiting requested review from shaneutt

@howardjohn howardjohn Awaiting requested review from howardjohn

@youngnick youngnick Awaiting requested review from youngnick

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dprotaso @robscott @k8s-ci-robot @sunjayBhatia @arkodg @mlavacca