Skip to content

Clarify port redirect behaviour and add conformance tests for the same #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 9, 2023
Merged

Clarify port redirect behaviour and add conformance tests for the same #1880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
102f93c
Update documentation to clarify redirect port behaviour and interacti…
gauravkghildiyal May 8, 2023
326a859
Do not include well known port in host header by default
gauravkghildiyal May 8, 2023
20ea954
Allow Location header to accept empty port when scheme implies the port
gauravkghildiyal May 8, 2023
718fc15
Add conformance tests for the interaction between redirect port and r…
gauravkghildiyal May 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion apis/v1beta1/httproute_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,6 +855,9 @@ type HTTPRequestRedirectFilter struct {
// Scheme is the scheme to be used in the value of the `Location` header in
// the response. When empty, the scheme of the request is used.
//
// Scheme redirects can affect the port of the redirect, for more information,
// refer to the documentation for the port field of this filter.
//
// Note that values may be added to this enum, implementations
// must ensure that unknown values will not cause a crash.
//
Expand Down Expand Up @@ -889,7 +892,15 @@ type HTTPRequestRedirectFilter struct {
// Port is the port to be used in the value of the `Location`
// header in the response.
//
// When empty, the Gateway Listener port is used.
// If no port is specified, the redirect port MUST be derived using the
// following rules:
//
// * If redirect scheme is not-empty, the redirect port MUST be the well-known
// port associated with the redirect scheme. Specifically "http" to port 80
// and "https" to port 443. If the redirect scheme does not have a
// well-known port, the listener port of the Gateway SHOULD be used.
// * If redirect scheme is empty, the redirect port MUST be the Gateway
// Listener port.
//
// Implementations SHOULD NOT add the port number in the 'Location'
// header in the following cases:
Expand Down
106 changes: 76 additions & 30 deletions config/crd/experimental/gateway.networking.k8s.io_httproutes.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading