Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEP 1709: initial implementation ideas #1754

Merged
merged 7 commits into from
Mar 1, 2023

Conversation

shaneutt
Copy link
Member

@shaneutt shaneutt commented Feb 22, 2023

What type of PR is this?

/kind gep

What this PR does / why we need it:

This contributes to #1709 and #1329 by adding the initial ideas for an implementation of conformance profiles to the relevant GEP.

Please note that the GEP remains in provisional state for this iteration so nothing that merges here is necessarily set in stone. Therefore if you have some lingering questions or concerns there will be more time to voice those concerns, and ideally even make your own PR making the changes that you want to see and helping co-author the GEP to pull in your ideas!

@shaneutt shaneutt added kind/gep PRs related to Gateway Enhancement Proposal(GEP) area/conformance labels Feb 22, 2023
@shaneutt shaneutt added this to the v1.0.0 milestone Feb 22, 2023
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 22, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2023
site-src/geps/gep-1709.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2023
geps/gep-1709.md Outdated Show resolved Hide resolved
@shaneutt shaneutt force-pushed the shaneutt/gep-1709-p2 branch 2 times, most recently from b783fca to d7665f0 Compare February 27, 2023 22:40
@shaneutt shaneutt requested review from howardjohn, sunjayBhatia and arkodg and removed request for arkodg February 27, 2023 22:41
@shaneutt shaneutt added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2023
@shaneutt
Copy link
Member Author

shaneutt commented Mar 1, 2023

@sunjayBhatia I'm marking this one as a merge hold for the moment to make sure we hear back from you as a stakeholder before we merge it.

@LiorLieberman
Copy link
Member

I like the changes. Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2023
@shaneutt shaneutt added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. and removed tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. labels Mar 1, 2023
Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me 👍🏽

I think regardless of how the implementation details etc. shake out (in terms of reporting schema, command line flags, etc.) I think the core ideas of what we want to get out of the centralized profiles/reporting are there!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkodg, LiorLieberman, shaneutt, sunjayBhatia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaneutt
Copy link
Member Author

shaneutt commented Mar 1, 2023

@youngnick as I understand it you wanted to give this a pass too, so keeping the hold on it until you've had a chance. Please feel free to remove the hold once you're happy with it 👍

Copy link
Contributor

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, I think a couple of things I consider imperative are already sorted here, nice work:

  • Using SkipTests on any Core features means you're not conformant
  • The output is machine parsable.

The one thing I'd add, non-blocking though, is an example of what the YAML would look like with failed tests. Not that I think anyone would submit that, but it will make it clearer for implementors.

Oh, and it would be good to add that the summary fields are free-form, we shouldn't require specific values there, or have that output be parsed or interpreted.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2023
@shaneutt
Copy link
Member Author

shaneutt commented Mar 1, 2023

  • Using SkipTests on any Core features means you're not conformant
  • The output is machine parsable.
  • The one thing I'd add, non-blocking though, is an example of what the YAML would look like with failed tests.

These things are already accounted for in the document:

https://github.com/kubernetes-sigs/gateway-api/pull/1754/files#diff-7764ccb47f68a80348b14a2c6df6c6cadd80db02de7817dbcb8039a611bf1328R127
https://github.com/kubernetes-sigs/gateway-api/pull/1754/files#diff-7764ccb47f68a80348b14a2c6df6c6cadd80db02de7817dbcb8039a611bf1328R369

Oh, and it would be good to add that the descriptions are free-form, we shouldn't require specific values there.

This one wasn't accounted for yet, I've added this in 6489c36 👍

@shaneutt shaneutt requested a review from youngnick March 1, 2023 23:01
@youngnick
Copy link
Contributor

/lgtm
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8ee91f2 into kubernetes-sigs:main Mar 1, 2023
@shaneutt shaneutt deleted the shaneutt/gep-1709-p2 branch March 1, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

8 participants