-
Notifications
You must be signed in to change notification settings - Fork 530
Define recommended conditions for policies #1673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define recommended conditions for policies #1673
Conversation
Welcome @mmamczur! |
Hi @mmamczur. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mmamczur!
f0184b1
to
1ef322e
Compare
Thanks @mmamczur! This LGTM but will defer to @shaneutt or @youngnick for approval. /lgtm |
/ok-to-test |
1ef322e
to
6e83691
Compare
Add recommended conditions and reasons that can be set in the policy status to GEP-713. kubernetes-sigs#1641 (comment)
6e83691
to
79612f7
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mmamczur, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#1675 has merged so tests should pass again /retest |
/lgtm |
What type of PR is this?
/kind feature
/kind gep
/kind documentation
What this PR does / why we need it:
Updates GEP-713 with recommended conditions and reasons that can be set in the policy status.
#1641