-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conformance: add attachedRoutes to conformance tests #1624
conformance: add attachedRoutes to conformance tests #1624
Conversation
Hi @ChaningHwang. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks @ChaningHwang! /ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ChaningHwang! This looks like a good start. Although this doesn't have to block merging this PR, I'd like to have this kind of logic in place across more tests before marking the linked issue as fixed.
d286af8
to
352f941
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the time I'm reading this, we're only testing for conditions where AttachedRoutes
is expected to be 0
, but to cover AttachedRoutes
in conformance we should in fact include some tests where it would be 1 and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't address the question of whether or not the attachedRoutes count should include routes that are attached to invalid not ready Gateways, but maybe the spec isn't going to mandate that one way or another?
Otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the positive cases, and thanks for your contribution! Targeting this for v0.7.0
.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChaningHwang, frankbu, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…Routes conformance: add attachedRoutes to conformance tests
What type of PR is this?
/kind feature
/area conformance
What this PR does / why we need it:
Add attachedRoutes to conformance tests.
Which issue(s) this PR fixes:
Fixes #1543
Does this PR introduce a user-facing change?:
NONE