Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup litespeed section on implementations page #1529

Merged
merged 3 commits into from
Nov 11, 2022

Conversation

rperper
Copy link
Contributor

@rperper rperper commented Nov 10, 2022

Added a section for the LiteSpeed Ingress Controller

What type of PR is this?

What this PR does / why we need it:

Announce LiteSpeed Ingress Controller Gateway API support.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

yes

Announce LiteSpeed Ingress Controller Gateway API support.

Added a section for the LiteSpeed Ingress Controller
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 10, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 10, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @rperper!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 10, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @rperper. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 10, 2022
@shaneutt
Copy link
Member

Looks like this needs a rebase against main, it's reverting recent updates to the same page.

Cleaned up the links
A bit better formatting.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 11, 2022
@rperper
Copy link
Contributor Author

rperper commented Nov 11, 2022

I think I've done everything. Is something missing?
Thanks!

Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rperper, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2022
@shaneutt shaneutt changed the title Update implementations.md chore: update litespeed on implementations page Nov 11, 2022
@shaneutt shaneutt changed the title chore: update litespeed on implementations page chore: cleanup litespeed section on implementations page Nov 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit c8cf3c3 into kubernetes-sigs:main Nov 11, 2022
@youngnick
Copy link
Contributor

Hmm, looks like this did revert the recent changes to the GKE implementation as well. @robscott, you may need to redo, I think.

@shaneutt
Copy link
Member

This is my bad. I originally saw this and mentioned it in this comment but somehow it got away from me. I cherry-picked @robscott's original commit back on top to revert those changes and also maintain Rob's attribution and authorship: #1535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants