-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup litespeed section on implementations page #1529
Conversation
Added a section for the LiteSpeed Ingress Controller
Welcome @rperper! |
Hi @rperper. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Looks like this needs a rebase against |
Cleaned up the links
A bit better formatting.
I think I've done everything. Is something missing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rperper, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hmm, looks like this did revert the recent changes to the GKE implementation as well. @robscott, you may need to redo, I think. |
This is my bad. I originally saw this and mentioned it in this comment but somehow it got away from me. I cherry-picked @robscott's original commit back on top to revert those changes and also maintain Rob's attribution and authorship: #1535 |
Added a section for the LiteSpeed Ingress Controller
What type of PR is this?
What this PR does / why we need it:
Announce LiteSpeed Ingress Controller Gateway API support.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:
yes