Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Docker image support multi OS archs #1462

Merged
merged 7 commits into from
Nov 9, 2022
Merged

Add Docker image support multi OS archs #1462

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3d1809c
Add docker image support both amd64 and arm64 with doc update
wilsonwu Oct 18, 2022
362b0dd
Add default platform env
wilsonwu Oct 30, 2022
67a7f17
> remove useless doc and update docker build and push
wilsonwu Nov 8, 2022
9a54192
Merge branch 'main' of github.com:wilsonwu/gateway-api
wilsonwu Nov 8, 2022
ae93d09
add build and push latest or semver (because buildx command can't sup…
wilsonwu Nov 8, 2022
27b1090
fix build and push multi tags in one cmd
wilsonwu Nov 9, 2022
d011951
fix indent
wilsonwu Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,14 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM golang:1.18 AS build-env
FROM --platform=$BUILDPLATFORM golang:1.18 AS build-env
RUN mkdir -p /go/src/sig.k8s.io/gateway-api
WORKDIR /go/src/sig.k8s.io/gateway-api
COPY . .
ARG TARGETARCH
ARG TAG
ARG COMMIT
RUN CGO_ENABLED=0 GOARCH=amd64 GOOS=linux go build -a -o gateway-api-webhook \
RUN CGO_ENABLED=0 GOARCH=$TARGETARCH GOOS=linux go build -a -o gateway-api-webhook \
-ldflags "-s -w -X main.VERSION=$TAG -X main.COMMIT=$COMMIT" ./cmd/admission

FROM gcr.io/distroless/static:nonroot
Expand Down
7 changes: 7 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,3 +68,10 @@ Participation in the Kubernetes community is governed by the
[concepts]: https://gateway-api.sigs.k8s.io/concepts/api-overview
[security-model]: https://gateway-api.sigs.k8s.io/concepts/security-model


## ARM Image Support

Use buildx for image building to support both amd64 and arm64:
```
docker buildx build -f Dockerfile -t registry/admission-server:tag . --platform linux/amd64,linux/arm64
```
wilsonwu marked this conversation as resolved.
Show resolved Hide resolved