Add Pending reason to GatewayClass, Gateway, Listener, and Routes #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Young <nick@isovalent.com>
k8s-ci-robot
added
kind/cleanup
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: youngnick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
youngnick
requested review from
mikemorris
and removed request for
keithmattix
youngnick
force-pushed
the
1449-add-pending-reason
branch
from
7f441fe
to
a43c8f9
Compare
Signed-off-by: Nick Young <nick@isovalent.com>
youngnick
force-pushed
the
1449-add-pending-reason
branch
from
a43c8f9
to
cc354e8
Compare
|
Thanks @youngnick! /lgtm |
k8s-ci-robot
added
the
lgtm
mikemorris
reviewed
Oct 13, 2022
| @@ -229,6 +233,9 @@ const ( | |||
|
|
|||
| // This reason is used with the "Accepted" condition when no controller has | |||
| // reconciled the Gateway. | |||
| GatewayReasonPending GatewayConditionReason = "Pending" | |||
There was a problem hiding this comment.
Nit, but I think this should be updated to match the Listener documentation to note it should also be used with the "Ready" condition when the status is "Unknown", added as a task to #1454
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind api-change
What this PR does / why we need it:
This adds a
PendingReason to:And deprecates the old Reasons associated with
Unknownstate.Which issue(s) this PR fixes:
Fixes #1449
Does this PR introduce a user-facing change?: