Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Flomesh Service Mesh as a downstream implementation #1421

Merged
merged 3 commits into from
Oct 6, 2022
Merged

Add Flomesh Service Mesh as a downstream implementation #1421

merged 3 commits into from
Oct 6, 2022

Conversation

naqvis
Copy link
Contributor

@naqvis naqvis commented Sep 30, 2022 •
edited
Loading

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Add Flomesh Service Mesh Ingress to the downstream implementation list. flomesh-io/fsm#18 is used to track the progress of implementation.

Which issue(s) this PR fixes:

none

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 30, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 30, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: naqvis / name: Ali Naqvi (7b1f199)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 30, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @naqvis. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 30, 2022
robscott
robscott reviewed Sep 30, 2022
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @naqvis!

site-src/implementations.md Outdated
The [Flomesh.io](flomesh) team is actively working towards an implementation of the Gateway API.

[fsm]:https://github.com/flomesh-io/fsm
[flomesh]:https://fomesh.io
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[flomesh]:https://fomesh.io
[flomesh]:https://flomesh.io

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch and apologies on making that typo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comment as above, it's possible that your change just never got pushed up.

site-src/implementations.md Outdated

[Flomesh Service Mesh][fsm] is a community driven Kubernetes North-South traffic manager, and provides an implementation of Ingress controller, Gateway API, Load Balancer, and cross-cluster service registration and service discovery.

The [Flomesh.io](flomesh) team is actively working towards an implementation of the Gateway API.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any links where we can track your progress towards Gateway API support? Even a GitHub issue or project would help.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have previously created flomesh-io/fsm#18 to track the implementation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you mind linking to that in your description, something like "You can track progress of this implementation here"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @robscott . I've updated PR description accordingly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @naqvis, you may have missed pushing your latest update, I still don't see a link to the tracking issue for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @robscott, I have updated the document and pushed commit#810ca6c. Previously I only made updates to the description of this PR.

robscott
robscott reviewed Oct 6, 2022
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @naqvis! Just a couple tiny nits but otherwise LGTM.

/ok-to-test
/approve

site-src/implementations.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 6, 2022
@naqvis @robscott
Update site-src/implementations.md
07f2688 
Co-authored-by: Rob Scott <rob.scott87@gmail.com>
@shaneutt shaneutt requested a review from robscott October 6, 2022 12:31
shaneutt
shaneutt approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'll wait for @robscott to double tap it 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: naqvis, robscott, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@robscott
Copy link
Member

robscott commented Oct 6, 2022

Thanks @naqvis!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit e60ed05 into kubernetes-sigs:main Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneutt shaneutt shaneutt approved these changes

@bowei bowei Awaiting requested review from bowei

@keithmattix keithmattix Awaiting requested review from keithmattix

@robscott robscott Awaiting requested review from robscott

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@naqvis @k8s-ci-robot @robscott @shaneutt