Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rectified Conformance Test Name Generation #1290

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Rectified Conformance Test Name Generation #1290

merged 1 commit into from
Aug 3, 2022

Conversation

abhijit-dev82
Copy link
Contributor

@abhijit-dev82 abhijit-dev82 commented Aug 1, 2022 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Conformance Test Name Generation is Flawed

Which issue(s) this PR fixes:

Fixes #1272

Does this PR introduce a user-facing change?:
No

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 1, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @abhijit-dev82. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhijit-dev82
Copy link
Contributor Author

While resolving merge conflicts the original #1283 got closed, hence had to open a new PR.

robscott
robscott reviewed Aug 2, 2022
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abhijit-dev82! This LGTM, works well for me, just a couple tiny nits.

/ok-to-test

conformance/utils/http/http.go Show resolved Hide resolved
conformance/utils/http/http.go Outdated
// Get User-defined test case name or generate from expected response to a given request.
func (er *ExpectedResponse) GetTestCaseName(i int) string {

/* If TestCase name is provided then use that or else generate one */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit: Would expect this to be a line comment (// instead of /*) per https://go.dev/doc/effective_go#commentary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 2, 2022
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 3, 2022
@abhijit-dev82 abhijit-dev82 force-pushed the test-name-fix branch 2 times, most recently from a9400ce to 39d7532 Compare August 3, 2022 04:27
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 3, 2022
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 3, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 3, 2022
@abhijit-dev82
Copy link
Contributor Author

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Aug 3, 2022
@k8s-ci-robot
Copy link
Contributor

@abhijit-dev82: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 3, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 3, 2022
@abhijit-dev82
Rectified Conformance Test Name Generation
66ee517 
Rectified Conformance Test Name Generation

Rectified Conformance Test Name Generation
@robscott
Copy link
Member

robscott commented Aug 3, 2022

Thanks @abhijit-dev82!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhijit-dev82, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit 361a156 into kubernetes-sigs:main Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott robscott left review comments

@bowei bowei Awaiting requested review from bowei

@keithmattix keithmattix Awaiting requested review from keithmattix

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conformance Test Name Generation is Flawed
3 participants
@abhijit-dev82 @k8s-ci-robot @robscott