Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Cilium Gateway API implementation #1280

Merged
merged 2 commits into from
Jul 26, 2022
Merged

[docs] Cilium Gateway API implementation #1280

merged 2 commits into from
Jul 26, 2022

Conversation

lizrice
Copy link
Contributor

@lizrice lizrice commented Jul 25, 2022

Add Cilium to list of Gateway API implementations

What type of PR is this?

/kind documentation

What this PR does / why we need it:
Adds Cilium to list of Gateway API implementations

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 25, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @lizrice!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 25, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @lizrice. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lizrice
Cilium Gateway API implementation
0179cd5 
Add Cilium to implementations of the Gateway API
markmc
markmc reviewed Jul 25, 2022
View reviewed changes
site-src/implementations.md Outdated Show resolved Hide resolved
markmc
markmc reviewed Jul 25, 2022
View reviewed changes
site-src/implementations.md Outdated Show resolved Hide resolved
@lizrice
[docs] Add links to Cilium issue and contact info
9ffbed1 
Add link to issue tracking Gateway API and contact info
@markmc
Copy link
Contributor

markmc commented Jul 26, 2022

Excellent, thank you

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2022
shaneutt
shaneutt approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lizrice, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit 67bef6c into kubernetes-sigs:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmc markmc markmc left review comments

@shaneutt shaneutt shaneutt approved these changes

@bowei bowei Awaiting requested review from bowei

@mikemorris mikemorris Awaiting requested review from mikemorris

Assignees

@markmc markmc

@shaneutt shaneutt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lizrice @k8s-ci-robot @markmc @shaneutt