-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds new tiny type for HTTPRoute Listeners in conformance tests #1228
Adds new tiny type for HTTPRoute Listeners in conformance tests #1228
Conversation
Hi @spencerhance. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Looks like you need a |
Adds a tiny type for specifying HTTPRoute ParentRefs to Gateways in the conformance tests.
9aca494
to
ddb1f08
Compare
Thanks @youngnick ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, seems like a fair way to handle the multiple parents 👍
/lgtm
Thanks @spencerhance! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, shaneutt, spencerhance The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind failing-test
What this PR does / why we need it:
Adds a tiny type for specifying HTTPRoute ParentRefs to Gateways
in the conformance tests. This allows us to test cases with 2 ParentRefs (to the same Gateway).
Which issue(s) this PR fixes:
Fixes #1219
Does this PR introduce a user-facing change?: