-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generating CRDs and client code for v1beta1, removing v1alpha1 #1197
Generating CRDs and client code for v1beta1, removing v1alpha1 #1197
Conversation
/cc @shaneutt @youngnick |
be238d5
to
c7b9089
Compare
5d6ce71
to
d13a69b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're pretty close to good, just a couple things:
The README is still linking directly to v1alpha1
:
[Go docs for the package](https://pkg.go.dev/sigs.k8s.io/gateway-api/apis/v1alpha1)
Looks like we should update that to v1beta1
.
Also looks like HAProxy refers to specifically having v1alpha1
support in implementations.md
:
HAProxy Ingress v0.13 partially supports the Gateway API's v1alpha1 specification. See the [controller's Gateway API documentation][h2] to get informed about conformance and roadmap.
Seems like we might want to give them a heads up, perhaps this is just out of date?
Other than that, I see a couple other references but those look like they can stay, historical stuff like blog posts and geps, e.t.c.
d13a69b
to
9a3be9e
Compare
9a3be9e
to
750f978
Compare
Good catches @shaneutt, thanks!
🤦 updated to v1alpha2 now (should eventually be v1b1).
@jcmoraisjr may have an update here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So there are a lot of changes in a single commit, but I looked through this and minus the things I pointed out above, I think we're good. 👍
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, with one small comment.
I did realize when reviewing this though, that I think that, if you only install the standard
channel CRDs, I don't think conformance will pass because ReferenceGrant is not present?
@@ -24,7 +24,6 @@ import ( | |||
// +kubebuilder:object:root=true | |||
// +kubebuilder:resource:categories=gateway-api,shortName=gtw | |||
// +kubebuilder:subresource:status | |||
// +kubebuilder:storageversion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm, we're leaving the storage version at v1alpha2 for now, and will migrate it later? This makes sense to me, but is probably worth calling out.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR makes a number of changes, primarily related to generating code for v1beta1 and removing v1alpha1 types:
Does this PR introduce a user-facing change?: