Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: remove ListenerReasonRouteConflict #1145

Merged
merged 1 commit into from
May 6, 2022
Merged

api: remove ListenerReasonRouteConflict #1145

merged 1 commit into from
May 6, 2022

Conversation

mikemorris
Copy link
Contributor

@mikemorris mikemorris commented May 4, 2022 •
edited
Loading

What type of PR is this?
/kind cleanup
/kind documentation
/kind api-change
/kind deprecation

What this PR does / why we need it:
This appears to be an artifact of the v1alpha1 configuration style where a listener selects routes directly. In v1alpha2 an unsupported route attempting to attach to a listener should instead be rejected by the gateway, and optionally set an Accepted RouteCondition with status False.

A somewhat-related mismatch between the Listener's AllowedRoutes kinds field and the supported protocol is explicitly expected to be expressed by the ResolvedRefs ListenerCondition setting status False with the InvalidRouteKinds reason (but could possibly be covered instead by webhook validation for the Core support level ProtocolType values and xRoute kinds?)

Which issue(s) this PR fixes:
Refs #1077, #935 (comment)

Does this PR introduce a user-facing change?:

removes the RouteConflict ListenerConditionReason intended to describe an error state that is no longer possible in the v1alpha2 API

@mikemorris
api: remove ListenerReasonRouteConflict
990beef 
This appears to be an artifact of the v1alpha1 configuration style where
a listener selects routes. In v1alpha2 an unsupported route should
instead be rejected by the gateway, and optionally set an Accepted
RouteCondition with status False.
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 4, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @mikemorris. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@robscott
Copy link
Member

robscott commented May 6, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 6, 2022
@robscott
Copy link
Member

robscott commented May 6, 2022

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikemorris, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit ef5f45f into kubernetes-sigs:master May 6, 2022
@mikemorris mikemorris deleted the api/remove-listener-reason-route-conflict branch May 6, 2022 18:10
@mikemorris mikemorris mentioned this pull request Jun 2, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpeach jpeach Awaiting requested review from jpeach

@thockin thockin Awaiting requested review from thockin

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikemorris @k8s-ci-robot @robscott