-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify docs generation & serve #113
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: M00nF1sh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9385f6f
to
3e56d39
Compare
thanks -- can you split the commit into two, one for the new build system, and all of the deleted files etc in the other (easier to review) |
3e56d39
to
36a902e
Compare
@bowei |
5b90376
to
2791f0c
Compare
My prior experience with having pip update stuff on the local system has been pretty hard to deal with, even with the python virtualization stuff (pyenv), so I would prefer the build to be completely hermetic via docker...after all it's what it was invented for :-) |
cool :D then the current one should be good, it's based on docker 🤣 |
@M00nF1sh: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@M00nF1sh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Hey @M00nF1sh, thanks for your initial work on this! Sorry we missed following up earlier. It looks like a lot has changed in the past few months so a rebase may end up being relatively complex. Since this PR has gone stale I'm going to close this for now, but still very open to this kind of approach. If you're still interested in this, don't hesitate to reopen the PR. /close |
@robscott: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes:
docs
folder. (it will be hosted ingh-pages
branch)docs-source
folder to bedocs
👀make docs-serve
: live-preview docs (renamedserve
to bedocs-serve
👀 )GITHUB_USER=<> GITHUB_TOKEN=<>make docs-deploy
: deploy docs togh-pages
branchSample page: https://m00nf1sh.github.io/service-apis/
Sample branch: https://github.com/M00nF1sh/service-apis/tree/gh-pages
TODO:
fix #34