Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete API Review and Approval Process for v1alpha2 #716

Closed
robscott opened this issue Jul 12, 2021 · 8 comments
Closed

Complete API Review and Approval Process for v1alpha2 #716

robscott opened this issue Jul 12, 2021 · 8 comments
Labels
api-review Categorizes an issue or PR as actively needing an API review.
Milestone

Comments

@robscott
Copy link
Member

As we're transitioning to a k8s.io API Group, we'll need formal review and approval for each new API release. Once this is complete, we'll need to update the annotations on the CRDs to reference the formal approval.

@robscott robscott added the api-review Categorizes an issue or PR as actively needing an API review. label Jul 12, 2021
@robscott robscott added this to the v1alpha2 milestone Jul 12, 2021
@hbagdi
Copy link
Contributor

hbagdi commented Jul 13, 2021

we'll need formal review and approval for each new API release

Are there any guidelines written up for this? Maybe not since there aren't many (any?) APIs outside k/k that are governed by the same approval process.
Do we have to follow the process for alpha APIs? What about beta?

@hbagdi
Copy link
Contributor

hbagdi commented Jul 13, 2021

I saw the v1alpha2 milestone after I posted my comment above. That explains that we need a review from API reviewers before any new API release.

@robscott
Copy link
Member Author

I think this is the best documentation around the process. I need to figure out exactly which parts of that we need to go through. I know in the past when I'd asked about a KEP for Gateway API it was considered unnecessary, but maybe it's required for this part of the process. Also want to check in with @thockin to see if he's more familiar with this process.

@bowei
Copy link
Contributor

bowei commented Jul 15, 2021 via email

@liggitt
Copy link

liggitt commented Aug 5, 2021

+1 to getting @thockin ack on the k8s.io change as soon as possible

@youngnick
Copy link
Contributor

youngnick commented Sep 21, 2021

Okay, so kubernetes/enhancements#2830 has merged, and I think we are down to one last feedback item from #861 (the backup review PR). Tim requested that we clarify if all Routes must have a ParentRef fields - I think the answer is yes, but I'll log a separate issue for it. (#874 )

I believe that once we've addressed that final feedback, the API review process is done, so we should be good to close this out and mark the review as finished? @robscott, thoughts?

@robscott
Copy link
Member Author

@andrewsykim @danwinship @khenidak @thockin Do you have any remaining feedback that needs to be addressed before we release v1alpha2?

@robscott
Copy link
Member Author

Missed closing this earlier, v1alpha2 was formally approved as part of the corresponding changelog PR (#891).

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-review Categorizes an issue or PR as actively needing an API review.
Projects
None yet
Development

No branches or pull requests

5 participants