-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete API Review and Approval Process for v1alpha2 #716
Comments
Are there any guidelines written up for this? Maybe not since there aren't many |
I saw the v1alpha2 milestone after I posted my comment above. That explains that we need a review from API reviewers before any new API release. |
I think this is the best documentation around the process. I need to figure out exactly which parts of that we need to go through. I know in the past when I'd asked about a KEP for Gateway API it was considered unnecessary, but maybe it's required for this part of the process. Also want to check in with @thockin to see if he's more familiar with this process. |
The KEP should be pretty skeletal (polint to our website)
Bowei
…On Mon, Jul 12, 2021 at 11:26 PM Rob Scott ***@***.***> wrote:
I think this is the best documentation
<https://github.com/kubernetes/community/blob/master/sig-architecture/api-review-process.md>
around the process. I need to figure out exactly which parts of that we
need to go through. I know in the past when I'd asked about a KEP for
Gateway API it was considered unnecessary, but maybe it's required for this
part of the process. Also want to check in with @thockin
<https://github.com/thockin> to see if he's more familiar with this
process.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#716 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGMLKQ43BBMFZ3EPIEWEFDTXPMDDANCNFSM5AHSW3LQ>
.
|
+1 to getting @thockin ack on the k8s.io change as soon as possible |
Okay, so kubernetes/enhancements#2830 has merged, and I think we are down to one last feedback item from #861 (the backup review PR). Tim requested that we clarify if all Routes must have a I believe that once we've addressed that final feedback, the API review process is done, so we should be good to close this out and mark the review as finished? @robscott, thoughts? |
@andrewsykim @danwinship @khenidak @thockin Do you have any remaining feedback that needs to be addressed before we release v1alpha2? |
Missed closing this earlier, v1alpha2 was formally approved as part of the corresponding changelog PR (#891). /close |
As we're transitioning to a k8s.io API Group, we'll need formal review and approval for each new API release. Once this is complete, we'll need to update the annotations on the CRDs to reference the formal approval.
The text was updated successfully, but these errors were encountered: