Consider naming TypedLocalObjectReference fields fooRef

[jpeach]

https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#naming-conventions

The name of a field referring to another resource of kind Foo by name should be called fooName. The name of a field referring to another resource of kind Foo by ObjectReference (or subset thereof) should be called fooRef.

Following this recommendation would replace Extension with ExtensionRef, but it would also replace ForwardTo with something less wieldy (maybe TargetRef). So maybe it's better not to follow this convention in all cases.

[bowei]

This reminds me of "Hungarian notation". I think we should try to make it align, but use common sense.

[Miciah]

While we consider the naming, we should also consider using custom types instead of ObjectReference and TypedLocalObjectReference, per the recommendation in kubernetes/kubernetes#87459. (Let me know if you would prefer a separate issue for the type issue.)

[bowei]

Let's open a PR against the developer guide section of the docs and continue the discussion there.

[jpeach]

/assign

[jpeach]

/unassign

[Miciah]

Opened #73 to replace types.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[robscott]

I believe this was fixed by #73, feel free to reopen if I missed anything.

[robscott]

/close

[k8s-ci-robot]

@robscott: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.