Skip to content

Conformance Tests: Base manifests for ingress use cases assume HTTP/HTTPS support #2403

Open
@shaneutt

Description

@shaneutt

What happened:

When trying to enable the conformance profiles enabled test suite for an implementation that supports Gateway but does NOT support HTTP/HTTPRoute, I discovered that we default to that protocol for the base manifests:

https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/base/manifests.yaml#L26
https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/utils/suite/suite.go#L131

This default doesn't make sense for an ingress implementation which doesn't support HTTPRoute.

Additionally, we have several tests that claim to only require support for Gateway but fail if the implementation doesn't present HTTPRoute in SupportedKinds, and generally rely on HTTPRoute.

What you expected to happen:

We need a way for the default cSuite.Setup() to work on ingress implementations that may not support the common HTTPRoute type. Mesh did this by providing different base manifests, and that's potentially on the table here, but it seems a little weird. Alternatively it might be reasonable to just make this more dynamic. We'll need to talk it over a bit.

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugCategorizes issue or PR as related to a bug.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.priority/important-longtermImportant over the long term, but may not be staffed and/or may need multiple releases to complete.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions