Conformance Tests: Base manifests for ingress use cases assume HTTP/HTTPS support #2403
Labels
kind/bug
Categorizes issue or PR as related to a bug.
lifecycle/rotten
Denotes an issue or PR that has aged beyond stale and will be auto-closed.
priority/important-longterm
Important over the long term, but may not be staffed and/or may need multiple releases to complete.
What happened:
When trying to enable the conformance profiles enabled test suite for an implementation that supports
Gateway
but does NOT supportHTTP
/HTTPRoute
, I discovered that we default to that protocol for the base manifests:https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/base/manifests.yaml#L26
https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/utils/suite/suite.go#L131
This default doesn't make sense for an ingress implementation which doesn't support
HTTPRoute
.Additionally, we have several tests that claim to only require support for
Gateway
but fail if the implementation doesn't presentHTTPRoute
inSupportedKinds
, and generally rely onHTTPRoute
.What you expected to happen:
We need a way for the default
cSuite.Setup()
to work on ingress implementations that may not support the commonHTTPRoute
type. Mesh did this by providing different base manifests, and that's potentially on the table here, but it seems a little weird. Alternatively it might be reasonable to just make this more dynamic. We'll need to talk it over a bit.The text was updated successfully, but these errors were encountered: