Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance Tests: Base manifests for ingress use cases assume HTTP/HTTPS support #2403

Open
shaneutt opened this issue Sep 15, 2023 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@shaneutt
Copy link
Member

shaneutt commented Sep 15, 2023

What happened:

When trying to enable the conformance profiles enabled test suite for an implementation that supports Gateway but does NOT support HTTP/HTTPRoute, I discovered that we default to that protocol for the base manifests:

https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/base/manifests.yaml#L26
https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/utils/suite/suite.go#L131

This default doesn't make sense for an ingress implementation which doesn't support HTTPRoute.

Additionally, we have several tests that claim to only require support for Gateway but fail if the implementation doesn't present HTTPRoute in SupportedKinds, and generally rely on HTTPRoute.

What you expected to happen:

We need a way for the default cSuite.Setup() to work on ingress implementations that may not support the common HTTPRoute type. Mesh did this by providing different base manifests, and that's potentially on the table here, but it seems a little weird. Alternatively it might be reasonable to just make this more dynamic. We'll need to talk it over a bit.

@shaneutt shaneutt added kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Sep 15, 2023
@shaneutt shaneutt changed the title Conformance Tests: Base manifests for ingress use cases assume HTTP support Conformance Tests: Base manifests for ingress use cases assume HTTP/HTTPS support Sep 15, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 28, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

3 participants