Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of ApiMachinery Sets with structs containing references #1703

Closed
shaneutt opened this issue Feb 7, 2023 · 3 comments · Fixed by #1707
Closed

Use of ApiMachinery Sets with structs containing references #1703

shaneutt opened this issue Feb 7, 2023 · 3 comments · Fixed by #1707
Labels
area/conformance kind/bug Categorizes issue or PR as related to a bug.
Milestone
v0.6.1

Comments

@shaneutt
Copy link
Member

shaneutt commented Feb 7, 2023

@skriss noticed while we were evaluating #1702 that some of the conformance test code wasn't working for him, particularly #1692 (comment) where the sets functionality from apimachinery was used with a struct with nested references. Sets does not currently support accurate Has(obj) functionality for structs with nested pointers, and so this test can not proceed properly.

Thank you @skriss! 🥳
@shaneutt shaneutt added kind/bug Categorizes issue or PR as related to a bug. area/conformance labels Feb 7, 2023
@shaneutt shaneutt added this to the v0.6.1 milestone Feb 7, 2023
This was referenced Feb 7, 2023
Merged
Merged
@arkodg arkodg mentioned this issue Feb 7, 2023
Merged
arkodg added a commit to arkodg/gateway-api that referenced this issue Feb 7, 2023
@arkodg
Add explicit equality checks for SupportedKinds
c437447 
Fixes: kubernetes-sigs#1703

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
arkodg added a commit to arkodg/gateway-api that referenced this issue Feb 7, 2023
@arkodg
Add explicit equality checks for SupportedKinds
2fb2c49 
Fixes: kubernetes-sigs#1703

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@shaneutt
Copy link
Member Author

shaneutt commented Feb 7, 2023

/assign @arkodg

@k8s-ci-robot
Copy link
Contributor

@shaneutt: GitHub didn't allow me to assign the following users: arkodg.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @arkodg

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shaneutt
Copy link
Member Author

shaneutt commented Feb 7, 2023

(@arkodg is working on this 👍 )

skriss added a commit to skriss/gateway-api that referenced this issue Feb 8, 2023
@skriss
add additional unit test case for kubernetes-sigs#1703
0fadaa2 
Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss mentioned this issue Feb 8, 2023
Merged
k8s-ci-robot added a commit that referenced this issue Feb 8, 2023
@k8s-ci-robot
Merge pull request #1710 from skriss/pr-1703-tc
0177808 
add additional unit test case for #1703
@shaneutt shaneutt mentioned this issue Jul 24, 2023
Closed
@shaneutt shaneutt mentioned this issue Aug 7, 2023
Closed
@shaneutt shaneutt mentioned this issue Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/conformance kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
v0.6.1
Development

Successfully merging a pull request may close this issue.

Add explicit equality checks for SupportedKinds arkodg/gateway-api
2 participants
@shaneutt @k8s-ci-robot