Skip to content

Commit

Permalink
Merge pull request #859 from robscott/tls-http-accepted
Browse files Browse the repository at this point in the history
Clarifying how HTTP and TLS Route status should be populated
  • Loading branch information
k8s-ci-robot authored Sep 10, 2021
2 parents 9e9e95c + 169b62f commit fc94bc2
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 16 deletions.
7 changes: 4 additions & 3 deletions apis/v1alpha2/httproute_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,10 @@ type HTTPRouteSpec struct {
// HTTPRoute specified `test.example.com` and `test.example.net`,
// `test.example.net` must not be considered for a match.
//
// If hostnames do not match with the criteria above, then the HTTPRoute is
// not accepted, and the implementation must raise an 'Accepted' Condition
// with a status of `False` for the target Listener(s).
// If both the Listener and HTTPRoute have specified hostnames, and none
// match with the criteria above, then the HTTPRoute is not accepted. The
// implementation must raise an 'Accepted' Condition with a status of
// `False` in the corresponding RouteParentStatus.
//
// Support: Core
//
Expand Down
7 changes: 4 additions & 3 deletions apis/v1alpha2/tlsroute_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,10 @@ type TLSRouteSpec struct {
// TLSRoute specified `test.example.com` and `test.example.net`,
// `test.example.net` must not be considered for a match.
//
// If all hostnames do not match with the criteria above, then the TLSRoute
// is not accepted, and the implementation must raise an 'Accepted'
// Condition with a status of `False` for the target Listener(s).
// If both the Listener and TLSRoute have specified hostnames, and none
// match with the criteria above, then the TLSRoute is not accepted. The
// implementation must raise an 'Accepted' Condition with a status of
// `False` in the corresponding RouteParentStatus.
//
// Support: Core
//
Expand Down
10 changes: 5 additions & 5 deletions config/crd/v1alpha2/gateway.networking.k8s.io_httproutes.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions config/crd/v1alpha2/gateway.networking.k8s.io_tlsroutes.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit fc94bc2

Please sign in to comment.