Skip to content

Commit

Permalink
drop Ready condition and allow old gateways to be present if mutabili…
Browse files Browse the repository at this point in the history
…ty fails
  • Loading branch information
dprotaso committed Jun 16, 2023
1 parent 1cc3093 commit a75f23e
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions geps/gep-1651.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,13 @@ signal the default routability using the Gateway's `status.addresses`. See 'Stat
for more details.

### Mutability

Implementations MAY prevent end-users from updating the `routability` value of a Gateway. If
updates are allowed the semantics and behaviour will depend on the underlying implementation.

If a Gateway is mutated but does not support the desired routability it MUST set the conditions
`Accepted`, `Ready`, `Programmed` to `False` with `Reason` set to `UnsupportedRoutability`.
`Accepted`, `Programmed` to `False` with `Reason` set to `UnsupportedRoutability`. Implementations
MAY choose to leave the old Gateway running with the previous generation's configuration.

### Go

Expand Down Expand Up @@ -136,7 +138,7 @@ type GatewayInfrastructure struct {
// Implementations MAY prevent end-users from updating the routability value of a Gateway.
// If updates are allowed the semantics and behaviour will depend on the underlying implementation.
// If a Gateway is mutated but does not support the desired routability it MUST set the conditions
// `Accepted`, `Ready`, `Programmed` to `False` with `Reason` set to `UnsupportedRoutability`.
// `Accepted`, `Programmed` to `False` with `Reason` set to `UnsupportedRoutability`.
//
// It is RECOMMENDED that in-cluster gateways SHOULD NOT support 'Private' routability.
// Kubernetes doesn't have a concept of 'Private' routability for Services. In the future this may
Expand Down

0 comments on commit a75f23e

Please sign in to comment.