Merge pull request #2138 from mmorel-35/linters

ci(linter): enable several linters

.golangci.yml

@@ -1,6 +1,8 @@
 run:
   timeout: 10m
   issues-exit-code: 1
+  max-issues-per-linter: 0
+  max-same-issues: 0
   tests: true
   skip-dirs-use-default: true
   modules-download-mode: readonly
@@ -9,13 +11,20 @@ run:
 linters:
   fast: false
   enable:
-  - gofmt
+  - errcheck
+  - exportloopref
+  - gocritic
+  - gofumpt
   - goimports
-  - revive
-  - govet
   - gomodguard
+  - gosec
+  - govet
   - misspell
-  - exportloopref
+  - revive
+  - unconvert
+  - unparam
+  - unused
+  - whitespace
   disable:
   - scopelint
   disable-all: false

apis/v1alpha2/validation/common.go

@@ -23,11 +23,9 @@ import (
 	gatewayvalidationv1b1 "sigs.k8s.io/gateway-api/apis/v1beta1/validation"
 )
 
-var (
-	// validateParentRefs validates ParentRefs SectionName must be set and uique
-	// when ParentRefs includes 2 or more references to the same parent
-	validateParentRefs = gatewayvalidationv1b1.ValidateParentRefs
-)
+// validateParentRefs validates ParentRefs SectionName must be set and uique
+// when ParentRefs includes 2 or more references to the same parent
+var validateParentRefs = gatewayvalidationv1b1.ValidateParentRefs
 
 // validateBackendRefServicePort validates whether or not a port was specified
 // for a backendRef which refers to a corev1.Service, asserting that the port

apis/v1beta1/validation/common.go

@@ -41,7 +41,7 @@ func ValidateParentRefs(parentRefs []gatewayv1b1.ParentReference, path *field.Pa
 	}
 	parentRefsSectionMap := make(map[sameKindParentRefs]sets.Set[parentQualifier])
 	for i, p := range parentRefs {
-		targetParentRefs := sameKindParentRefs{name: p.Name, namespace: *new(gatewayv1b1.Namespace), kind: *new(gatewayv1b1.Kind)}
+		targetParentRefs := sameKindParentRefs{name: p.Name, namespace: gatewayv1b1.Namespace(""), kind: gatewayv1b1.Kind("")}
 		pq := parentQualifier{}
 		if p.Namespace != nil {
 			targetParentRefs.namespace = *p.Namespace

apis/v1beta1/validation/common_test.go

@@ -25,7 +25,7 @@ import (
 	gatewayv1b1 "sigs.k8s.io/gateway-api/apis/v1beta1"
 )
 
-var path = *new(field.Path)
+var path = field.Path{}
 
 func TestValidateParentRefs(t *testing.T) {
 	namespace := gatewayv1b1.Namespace("example-namespace")

conformance/tests/gateway-modify-listeners.go

@@ -43,7 +43,6 @@ var GatewayModifyListeners = suite.ConformanceTest{
 	},
 	Manifests: []string{"tests/gateway-modify-listeners.yaml"},
 	Test: func(t *testing.T, s *suite.ConformanceTestSuite) {
-
 		t.Run("should be able to add a listener that then becomes available for routing traffic", func(t *testing.T) {
 			gwNN := types.NamespacedName{Name: "gateway-add-listener", Namespace: "gateway-conformance-infra"}
 			ctx, cancel := context.WithTimeout(context.Background(), time.Minute)
@@ -93,7 +92,7 @@ var GatewayModifyListeners = suite.ConformanceTest{
 					Conditions: []metav1.Condition{{
 						Type:   string(v1beta1.ListenerConditionAccepted),
 						Status: metav1.ConditionTrue,
-						Reason: "", //any reason
+						Reason: "", // any reason
 					}},
 					AttachedRoutes: 1,
 				},
@@ -106,7 +105,7 @@ var GatewayModifyListeners = suite.ConformanceTest{
 					Conditions: []metav1.Condition{{
 						Type:   string(v1beta1.ListenerConditionAccepted),
 						Status: metav1.ConditionTrue,
-						Reason: "", //any reason
+						Reason: "", // any reason
 					}},
 					AttachedRoutes: 1,
 				},
@@ -165,7 +164,7 @@ var GatewayModifyListeners = suite.ConformanceTest{
 					Conditions: []metav1.Condition{{
 						Type:   string(v1beta1.ListenerConditionAccepted),
 						Status: metav1.ConditionTrue,
-						Reason: "", //any reason
+						Reason: "", // any reason
 					}},
 					AttachedRoutes: 1,
 				},

conformance/tests/gateway-observed-generation-bump.go

@@ -42,7 +42,6 @@ var GatewayObservedGenerationBump = suite.ConformanceTest{
 	},
 	Manifests: []string{"tests/gateway-observed-generation-bump.yaml"},
 	Test: func(t *testing.T, s *suite.ConformanceTestSuite) {
-
 		gwNN := types.NamespacedName{Name: "gateway-observed-generation-bump", Namespace: "gateway-conformance-infra"}
 
 		t.Run("observedGeneration should increment", func(t *testing.T) {

conformance/tests/gateway-with-attached-routes.go

@@ -50,7 +50,7 @@ var GatewayWithAttachedRoutes = suite.ConformanceTest{
 				Conditions: []metav1.Condition{{
 					Type:   string(v1beta1.ListenerConditionAccepted),
 					Status: metav1.ConditionTrue,
-					Reason: "", //any reason
+					Reason: "", // any reason
 				}},
 				AttachedRoutes: 1,
 			}}
@@ -69,7 +69,7 @@ var GatewayWithAttachedRoutes = suite.ConformanceTest{
 				Conditions: []metav1.Condition{{
 					Type:   string(v1beta1.ListenerConditionAccepted),
 					Status: metav1.ConditionTrue,
-					Reason: "", //any reason
+					Reason: "", // any reason
 				}},
 				AttachedRoutes: 2,
 			}}

conformance/tests/httproute-invalid-backendref-nonexistent.go

@@ -66,6 +66,5 @@ var HTTPRouteInvalidNonExistentBackendRef = suite.ConformanceTest{
 				Response: http.Response{StatusCode: 500},
 			})
 		})
-
 	},
 }

conformance/tests/httproute-invalid-backendref-unknown-kind.go

@@ -67,6 +67,5 @@ var HTTPRouteInvalidBackendRefUnknownKind = suite.ConformanceTest{
 				Response: http.Response{StatusCode: 500},
 			})
 		})
-
 	},
 }

conformance/tests/httproute-invalid-cross-namespace-backend-ref.go

@@ -49,7 +49,6 @@ var HTTPRouteInvalidCrossNamespaceBackendRef = suite.ConformanceTest{
 		gwAddr := kubernetes.GatewayAndHTTPRoutesMustBeAccepted(t, suite.Client, suite.TimeoutConfig, suite.ControllerName, kubernetes.NewGatewayRef(gwNN), routeNN)
 
 		t.Run("HTTPRoute with a cross-namespace BackendRef and no ReferenceGrant has a ResolvedRefs Condition with status False and Reason RefNotPermitted", func(t *testing.T) {
-
 			resolvedRefsCond := metav1.Condition{
 				Type:   string(v1beta1.RouteConditionResolvedRefs),
 				Status: metav1.ConditionFalse,
@@ -68,6 +67,5 @@ var HTTPRouteInvalidCrossNamespaceBackendRef = suite.ConformanceTest{
 				Response: http.Response{StatusCode: 500},
 			})
 		})
-
 	},
 }

conformance/tests/httproute-partially-invalid-via-reference-grant.go

@@ -49,7 +49,6 @@ var HTTPRoutePartiallyInvalidViaInvalidReferenceGrant = suite.ConformanceTest{
 		gwAddr := kubernetes.GatewayAndHTTPRoutesMustBeAccepted(t, s.Client, s.TimeoutConfig, s.ControllerName, kubernetes.NewGatewayRef(gwNN), routeNN)
 
 		t.Run("HTTPRoute with BackendRef in another namespace and no ReferenceGrant covering the Service has a ResolvedRefs Condition with status False and Reason RefNotPermitted", func(t *testing.T) {
-
 			resolvedRefsCond := metav1.Condition{
 				Type:   string(v1beta1.RouteConditionResolvedRefs),
 				Status: metav1.ConditionFalse,
@@ -80,6 +79,5 @@ var HTTPRoutePartiallyInvalidViaInvalidReferenceGrant = suite.ConformanceTest{
 				Namespace: "gateway-conformance-app-backend",
 			})
 		})
-
 	},
 }

conformance/tests/httproute-path-match-order.go

@@ -45,31 +45,32 @@ var HTTPRoutePathMatchOrder = suite.ConformanceTest{
 		gwAddr := kubernetes.GatewayAndHTTPRoutesMustBeAccepted(t, suite.Client, suite.TimeoutConfig, suite.ControllerName, kubernetes.NewGatewayRef(gwNN), routeNN)
 		kubernetes.HTTPRouteMustHaveResolvedRefsConditionsTrue(t, suite.Client, suite.TimeoutConfig, routeNN, gwNN)
 
-		testCases := []http.ExpectedResponse{{
-			Request:   http.Request{Path: "/match/exact/one"},
-			Backend:   "infra-backend-v3",
-			Namespace: ns,
-		}, {
-			Request:   http.Request{Path: "/match/exact"},
-			Backend:   "infra-backend-v2",
-			Namespace: ns,
-		}, {
-			Request:   http.Request{Path: "/match"},
-			Backend:   "infra-backend-v1",
-			Namespace: ns,
-		}, {
-			Request:   http.Request{Path: "/match/prefix/one/any"},
-			Backend:   "infra-backend-v2",
-			Namespace: ns,
-		}, {
-			Request:   http.Request{Path: "/match/prefix/any"},
-			Backend:   "infra-backend-v1",
-			Namespace: ns,
-		}, {
-			Request:   http.Request{Path: "/match/any"},
-			Backend:   "infra-backend-v3",
-			Namespace: ns,
-		},
+		testCases := []http.ExpectedResponse{
+			{
+				Request:   http.Request{Path: "/match/exact/one"},
+				Backend:   "infra-backend-v3",
+				Namespace: ns,
+			}, {
+				Request:   http.Request{Path: "/match/exact"},
+				Backend:   "infra-backend-v2",
+				Namespace: ns,
+			}, {
+				Request:   http.Request{Path: "/match"},
+				Backend:   "infra-backend-v1",
+				Namespace: ns,
+			}, {
+				Request:   http.Request{Path: "/match/prefix/one/any"},
+				Backend:   "infra-backend-v2",
+				Namespace: ns,
+			}, {
+				Request:   http.Request{Path: "/match/prefix/any"},
+				Backend:   "infra-backend-v1",
+				Namespace: ns,
+			}, {
+				Request:   http.Request{Path: "/match/any"},
+				Backend:   "infra-backend-v3",
+				Namespace: ns,
+			},
 		}
 
 		for i := range testCases {

conformance/tests/httproute-redirect-host-and-status.go

@@ -46,31 +46,32 @@ var HTTPRouteRedirectHostAndStatus = suite.ConformanceTest{
 		gwAddr := kubernetes.GatewayAndHTTPRoutesMustBeAccepted(t, suite.Client, suite.TimeoutConfig, suite.ControllerName, kubernetes.NewGatewayRef(gwNN), routeNN)
 		kubernetes.HTTPRouteMustHaveResolvedRefsConditionsTrue(t, suite.Client, suite.TimeoutConfig, routeNN, gwNN)
 
-		testCases := []http.ExpectedResponse{{
-			Request: http.Request{
-				Path:             "/hostname-redirect",
-				UnfollowRedirect: true,
+		testCases := []http.ExpectedResponse{
+			{
+				Request: http.Request{
+					Path:             "/hostname-redirect",
+					UnfollowRedirect: true,
+				},
+				Response: http.Response{
+					StatusCode: 302,
+				},
+				RedirectRequest: &roundtripper.RedirectRequest{
+					Host: "example.org",
+				},
+				Namespace: ns,
+			}, {
+				Request: http.Request{
+					Path:             "/host-and-status",
+					UnfollowRedirect: true,
+				},
+				Response: http.Response{
+					StatusCode: 301,
+				},
+				RedirectRequest: &roundtripper.RedirectRequest{
+					Host: "example.org",
+				},
+				Namespace: ns,
 			},
-			Response: http.Response{
-				StatusCode: 302,
-			},
-			RedirectRequest: &roundtripper.RedirectRequest{
-				Host: "example.org",
-			},
-			Namespace: ns,
-		}, {
-			Request: http.Request{
-				Path:             "/host-and-status",
-				UnfollowRedirect: true,
-			},
-			Response: http.Response{
-				StatusCode: 301,
-			},
-			RedirectRequest: &roundtripper.RedirectRequest{
-				Host: "example.org",
-			},
-			Namespace: ns,
-		},
 		}
 		for i := range testCases {
 			// Declare tc here to avoid loop variable