Skip to content

fix(Conformance): Add namespace-(labels|annotations) flag parsing #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged

fix(Conformance): Add namespace-(labels|annotations) flag parsing #984

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions conformance/conformance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,9 @@ func DefaultOptions(t *testing.T) confsuite.ConformanceOptions {

exemptFeatures := confsuite.ParseSupportedFeatures(*confflags.ExemptFeatures)
skipTests := confsuite.ParseSkipTests(*confflags.SkipTests)
namespaceLabels := confsuite.ParseKeyValuePairs(*confflags.NamespaceLabels)
namespaceAnnotations := confsuite.ParseKeyValuePairs(*confflags.NamespaceAnnotations)

// Initially, run the GatewayLayerProfile. This will expand as other profiles
// (EPP, ModelServer) are added and can be selected via flags in future iterations.
conformanceProfiles := sets.New(GatewayLayerProfileName)
Expand Down Expand Up @@ -173,6 +176,8 @@ func DefaultOptions(t *testing.T) confsuite.ConformanceOptions {
ManifestFS: []fs.FS{&Manifests},
ReportOutputPath: *confflags.ReportOutput,
SkipProvisionalTests: *confflags.SkipProvisionalTests,
NamespaceLabels: namespaceLabels,
NamespaceAnnotations: namespaceAnnotations,
Comment on lines +179 to +180
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SinaChavoshi will any of your outstanding PRs benefit from this change?

// TODO: Add the inference extension specific fields to ConformanceOptions struct if needed,
// or handle them during report generation.
// GatewayAPIInferenceExtensionChannel: inferenceExtensionChannel,
Expand Down