generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 179
Add subsetting logic for epp #981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89 changes: 89 additions & 0 deletions
89
pkg/epp/scheduling/framework/plugins/filter/subsetting_filter.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
/* | ||
Copyright 2025 The Kubernetes Authors. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package filter | ||
|
||
import ( | ||
"context" | ||
"strings" | ||
|
||
"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/scheduling/framework" | ||
"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/scheduling/types" | ||
) | ||
|
||
const ( | ||
SubsetFilterType = "subset" | ||
|
||
subsetHintKey = "x-gateway-destination-endpoint-subset" | ||
subsetHintNamespace = "envoy.lb.subset_hint" | ||
) | ||
|
||
// compile-time type assertion | ||
var _ framework.Filter = &SubsetFilter{} | ||
|
||
// NewSubsetFilter initializes a new SubsetFilter. | ||
func NewSubsetFilter() *SubsetFilter { | ||
return &SubsetFilter{} | ||
} | ||
|
||
// SubsetFilter filters Pods based on the subset hint provided by the proxy via filterMetadata. | ||
type SubsetFilter struct{} | ||
|
||
// Name returns the name of the filter. | ||
func (f *SubsetFilter) Name() string { | ||
return "subset-hint" | ||
} | ||
|
||
// Type returns the type of the filter. | ||
func (f *SubsetFilter) Type() string { | ||
return SubsetFilterType | ||
} | ||
|
||
// Filter filters out pods that are not in the subset provided in filterMetadata. | ||
func (f *SubsetFilter) Filter(_ context.Context, _ *types.CycleState, request *types.LLMRequest, pods []types.Pod) []types.Pod { | ||
// Check if subset namespace key is present in the metadata map | ||
subsetMap, found := request.GetMetadata()[subsetHintNamespace].(map[string]any) | ||
if !found { | ||
return pods | ||
} | ||
|
||
// Check if endpoint key is present in the subset map and ensure there is at least one value | ||
endpointSubsetList, found := subsetMap[subsetHintKey].([]interface{}) | ||
rlakhtakia marked this conversation as resolved.
Show resolved
Hide resolved
|
||
if !found { | ||
return pods | ||
} else if len(endpointSubsetList) == 0 { | ||
return []types.Pod{} | ||
} | ||
|
||
// Create a map of endpoint addrs for easy lookup | ||
endpoints := make(map[string]bool) | ||
for _, endpoint := range endpointSubsetList { | ||
// Extract address from endpoint | ||
// The endpoint is formatted as "<address>:<port>" (ex. "10.0.1.0:8080") | ||
epStr := strings.Split(endpoint.(string), ":")[0] | ||
rlakhtakia marked this conversation as resolved.
Show resolved
Hide resolved
|
||
endpoints[epStr] = true | ||
} | ||
|
||
// Filter based on address | ||
filteredPods := []types.Pod{} | ||
for _, pod := range pods { | ||
if _, found := endpoints[pod.GetPod().Address]; found { | ||
filteredPods = append(filteredPods, pod) | ||
} | ||
} | ||
|
||
return filteredPods | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
/* | ||
Copyright 2025 The Kubernetes Authors. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package request | ||
|
||
import ( | ||
extProcPb "github.com/envoyproxy/go-control-plane/envoy/service/ext_proc/v3" | ||
) | ||
|
||
func ExtractMetadataValues(req *extProcPb.ProcessingRequest) map[string]any { | ||
metadata := make(map[string]any) | ||
if req != nil && req.MetadataContext != nil && req.MetadataContext.FilterMetadata != nil { | ||
for key, val := range req.MetadataContext.FilterMetadata { | ||
metadata[key] = val.AsMap() | ||
} | ||
} | ||
return metadata | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine for now, but please open an issue to allow configuring this across profiles irrespective of the source of the configuration (see the discussion we had on the issue)