-
Notifications
You must be signed in to change notification settings - Fork 179
add e2e test for epp metrics #938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Hang Yin <luying.yh@alibaba-inc.com>
Hi @delavet. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
/ok-to-test |
@delavet great job with this PR. Fix the linter issue and all should be good. /lgtm |
Sorry for these linter issues. They have been resolved, please help check this again @danehans |
This looks great! Sorry its sat for so long
Do we have an issue created yet? This would be great to track |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: delavet, kfswain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yes! this is the issue tracking it #939 . |
* add e2e test for epp metrics Signed-off-by: Hang Yin <luying.yh@alibaba-inc.com> * fix linting --------- Signed-off-by: Hang Yin <luying.yh@alibaba-inc.com>
* add e2e test for epp metrics Signed-off-by: Hang Yin <luying.yh@alibaba-inc.com> * fix linting --------- Signed-off-by: Hang Yin <luying.yh@alibaba-inc.com>
* add e2e test for epp metrics Signed-off-by: Hang Yin <luying.yh@alibaba-inc.com> * fix linting --------- Signed-off-by: Hang Yin <luying.yh@alibaba-inc.com>
* add e2e test for epp metrics Signed-off-by: Hang Yin <luying.yh@alibaba-inc.com> * fix linting --------- Signed-off-by: Hang Yin <luying.yh@alibaba-inc.com>
* add e2e test for epp metrics Signed-off-by: Hang Yin <luying.yh@alibaba-inc.com> * fix linting --------- Signed-off-by: Hang Yin <luying.yh@alibaba-inc.com>
This PR is related to #915 and adds an e2e test case to verify whether the epp exposes the correct metrics after traffic is generated.
This e2e test actually revealed an issue: currently the
normalized_time_per_output_token_seconds
metric is not being recorded correctly. However, to maintain the atomicity of this PR, I have left a TODO and will consider submitting a new issue to track the problem I discovered.