Skip to content

Conversation

delavet
Copy link
Contributor

@delavet delavet commented Jun 9, 2025

This PR is related to #915 and adds an e2e test case to verify whether the epp exposes the correct metrics after traffic is generated.
This e2e test actually revealed an issue: currently the normalized_time_per_output_token_seconds metric is not being recorded correctly. However, to maintain the atomicity of this PR, I have left a TODO and will consider submitting a new issue to track the problem I discovered.

Signed-off-by: Hang Yin <luying.yh@alibaba-inc.com>
@k8s-ci-robot k8s-ci-robot requested review from Jeffwan and robscott June 9, 2025 02:04
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 9, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @delavet. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 9, 2025
Copy link

netlify bot commented Jun 9, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 9686fb4
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6858a80288d19500085ef43a
😎 Deploy Preview https://deploy-preview-938--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@danehans
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 19, 2025
@danehans
Copy link
Contributor

@delavet great job with this PR. Fix the linter issue and all should be good.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2025
@delavet
Copy link
Contributor Author

delavet commented Jun 24, 2025

Sorry for these linter issues. They have been resolved, please help check this again @danehans

@kfswain
Copy link
Collaborator

kfswain commented Jun 24, 2025

This looks great! Sorry its sat for so long
/lgtm

normalized_time_per_output_token_seconds metric is not being recorded correctly. However, to maintain the atomicity of this PR, I have left a TODO and will consider submitting a new issue to track the problem I discovered.

Do we have an issue created yet? This would be great to track

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2025
@kfswain
Copy link
Collaborator

kfswain commented Jun 24, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: delavet, kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit df147db into kubernetes-sigs:main Jun 24, 2025
9 checks passed
@delavet
Copy link
Contributor Author

delavet commented Jun 25, 2025

This looks great! Sorry its sat for so long /lgtm

normalized_time_per_output_token_seconds metric is not being recorded correctly. However, to maintain the atomicity of this PR, I have left a TODO and will consider submitting a new issue to track the problem I discovered.

Do we have an issue created yet? This would be great to track

Yes! this is the issue tracking it #939 .

shmuelk pushed a commit to shmuelk/gateway-api-inference-extension that referenced this pull request Jun 25, 2025
* add e2e test for epp metrics

Signed-off-by: Hang Yin <luying.yh@alibaba-inc.com>

* fix linting

---------

Signed-off-by: Hang Yin <luying.yh@alibaba-inc.com>
rlakhtakia pushed a commit to rlakhtakia/gateway-api-inference-extension that referenced this pull request Jun 26, 2025
* add e2e test for epp metrics

Signed-off-by: Hang Yin <luying.yh@alibaba-inc.com>

* fix linting

---------

Signed-off-by: Hang Yin <luying.yh@alibaba-inc.com>
rlakhtakia pushed a commit to rlakhtakia/gateway-api-inference-extension that referenced this pull request Jun 26, 2025
* add e2e test for epp metrics

Signed-off-by: Hang Yin <luying.yh@alibaba-inc.com>

* fix linting

---------

Signed-off-by: Hang Yin <luying.yh@alibaba-inc.com>
EyalPazz pushed a commit to EyalPazz/gateway-api-inference-extension that referenced this pull request Jul 9, 2025
* add e2e test for epp metrics

Signed-off-by: Hang Yin <luying.yh@alibaba-inc.com>

* fix linting

---------

Signed-off-by: Hang Yin <luying.yh@alibaba-inc.com>
BenjaminBraunDev pushed a commit to BenjaminBraunDev/gateway-api-inference-extension that referenced this pull request Aug 12, 2025
* add e2e test for epp metrics

Signed-off-by: Hang Yin <luying.yh@alibaba-inc.com>

* fix linting

---------

Signed-off-by: Hang Yin <luying.yh@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants