Skip to content

Conversation

SinaChavoshi
Copy link
Contributor

This PR introduces a new conformance test, inferencepool_backend_service_no_endpoints. This test is designed to validate the behavior and status reporting of an InferencePool and its associated HTTPRoute when the InferencePool references a Kubernetes Service that has no active endpoints (i.e., no backing Pods).

local run results: ( Ran on commit 825d8 )

go test -v ./conformance -args -debug     -gateway-class gke-l7-regional-external-managed     -cleanup-base-resources=false     -run-test InferencePoolBackendServiceNoEndpoints
=== RUN   TestConformance
    conformance.go:198: Registering API types with scheme...
...
    apply.go:279: 2025-05-13T00:37:28.553576236Z: Deleting httproute-for-pool-no-endpoints HTTPRoute
    apply.go:279: 2025-05-13T00:37:28.672641818Z: Deleting pool-no-endpoints InferencePool
    apply.go:279: 2025-05-13T00:37:28.782958484Z: Deleting backend-svc-no-endpoints Service
--- PASS: TestConformance (124.59s)
    --- SKIP: TestConformance/InferencePoolAccepted (0.00s)
    --- PASS: TestConformance/InferencePoolBackendServiceNoEndpoints (121.40s)
        --- PASS: TestConformance/InferencePoolBackendServiceNoEndpoints/InferencePool_should_have_Accepted_condition_set_to_True (110.06s)
        --- PASS: TestConformance/InferencePoolBackendServiceNoEndpoints/InferencePool_should_have_ResolvedRefs_condition_set_to_True (0.05s)
PASS
ok 

Copy link

netlify bot commented May 13, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit bedaae4
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/6824ddd06455f70008e8fa19
😎 Deploy Preview https://deploy-preview-826--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SinaChavoshi
Once this PR has been reviewed and has the lgtm label, please assign sergeykanzhelev for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 13, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and robscott May 13, 2025 00:42
@k8s-ci-robot
Copy link
Contributor

Hi @SinaChavoshi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 13, 2025
@kfswain
Copy link
Collaborator

kfswain commented May 13, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 13, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2025
@SinaChavoshi
Copy link
Contributor Author

Closing the PR per discussion on #807 this test is not correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants