feat(conformance): Add initial InferencePool tests and shared Gateway setup #772

SinaChavoshi · 2025-05-01T19:28:11Z

This PR introduces the foundational elements for the Gateway API Inference Extension conformance test suite, including the first set of tests for InferencePool resources and the necessary setup for a shared Gateway.

local run results: ( ran on latest commit d8577b0)

go test -v ./... -args     -gateway-class gke-l7-regional-external-managed     -cleanup-base-resources=false 
...
=== NAME  TestConformance/InferencePoolAccepted
    apply.go:279: 2025-05-09T20:22:11.212232453Z: Deleting httproute-for-inferencepool-accepted HTTPRoute
    apply.go:279: 2025-05-09T20:22:11.328760314Z: Deleting inferencepool-basic-accepted InferencePool
    apply.go:279: 2025-05-09T20:22:11.436449131Z: Deleting infra-backend-v1-deployment Deployment
--- PASS: TestConformance (44.48s)
    --- PASS: TestConformance/InferencePoolAccepted (41.33s)
        --- PASS: TestConformance/InferencePoolAccepted/InferencePool_should_have_Accepted_condition_set_to_True (40.06s)
PASS
ok      sigs.k8s.io/gateway-api-inference-extension/conformance 44.554s
...

k8s-ci-robot · 2025-05-01T19:28:21Z

Hi @SinaChavoshi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

netlify · 2025-05-01T19:28:32Z

✅ Deploy Preview for gateway-api-inference-extension ready!

Name	Link
🔨 Latest commit	`d8577b0`
🔍 Latest deploy log	https://app.netlify.com/sites/gateway-api-inference-extension/deploys/681e6270e2712b00083ee9d9
😎 Deploy Preview	https://deploy-preview-772--gateway-api-inference-extension.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ahg-g · 2025-05-04T19:49:12Z

/ok-to-test

SinaChavoshi · 2025-05-05T17:39:10Z

/retest

LiorLieberman · 2025-05-05T21:56:53Z

/assign

LiorLieberman · 2025-05-05T21:56:58Z

/cc

spencerhance · 2025-05-05T22:03:08Z

/cc

LiorLieberman

Thank you @SinaChavoshi !

Overall looks good, left some initial comments

conformance/conformance.go

conformance/resources/manifests/manifests.yaml

…teway"

Co-authored-by: Lior Lieberman <liorlib7+riskified@gmail.com>

LiorLieberman

Thanks Sina, looks good!

Is the PR description conformance execution was done after the change?

SinaChavoshi · 2025-05-06T21:56:20Z

Thanks Sina, looks good!

Is the PR description conformance execution was done after the change?

Good call! updated the description with a test run results from the latest commit.

LiorLieberman

This is great.
LGTM.

ping me once done so I can leave lgtm - if I leave it now it will be removed when you do any further changes

conformance/conformance.go

conformance/utils/kubernetes/helpers.go

LiorLieberman

Thanks!
/lgtm

SinaChavoshi · 2025-05-07T18:40:34Z

/assign @danehans

conformance/conformance.go

danehans

/lgtm
/approve

conformance/utils/kubernetes/helpers.go

conformance/conformance.go

k8s-ci-robot · 2025-05-09T21:35:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans, LiorLieberman, SinaChavoshi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [danehans]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

… setup (kubernetes-sigs#772) * Add inferencepool_lifecycle test. * Resolve setup issues and enable InferencePool test * correct Lint error Multiplication of durations * Fix missing containerPort, is missing * change gateway name from "gateway-conformance-app" to "conformance-gateway" * clarify why K8s types are needed. * Update conformance/conformance.go Co-authored-by: Lior Lieberman <liorlib7+riskified@gmail.com> * Update conformance/conformance.go Co-authored-by: Lior Lieberman <liorlib7+riskified@gmail.com> * remove for loop when adding SupportedFeatures * remove exessive logging * Update conformance/conformance.go Co-authored-by: Lior Lieberman <liorlib7+riskified@gmail.com> * move excess debug logs behind debug flag. * remove CONFORMANCE.GO prefix from logs. * change the pull logic and use default value from GatewayMustHaveAddress * fix mt.Sprintf can be replaced with string concatenation * add a function for logDebug * factor out ensureGatewayAvailableAndReady * removed todo comment in helper.go * remove CONFORMANCE.GO from log * error messages, should not be capitalized or end with punctuation --------- Co-authored-by: Lior Lieberman <liorlib7+riskified@gmail.com>

Add inferencepool_lifecycle test.

eae4c99

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 1, 2025

k8s-ci-robot requested review from ahg-g and robscott May 1, 2025 19:28

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 1, 2025

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 1, 2025

SinaChavoshi changed the title ~~feat(conformance): Add initial InferencePool tests and shared Gateway setup~~ [WIP]feat(conformance): Add initial InferencePool tests and shared Gateway setup May 1, 2025

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 1, 2025

Resolve setup issues and enable InferencePool test

404f522

SinaChavoshi changed the title ~~[WIP]feat(conformance): Add initial InferencePool tests and shared Gateway setup~~ feat(conformance): Add initial InferencePool tests and shared Gateway setup May 2, 2025

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 2, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 4, 2025

correct Lint error Multiplication of durations

d396ecb

k8s-ci-robot assigned LiorLieberman May 5, 2025

k8s-ci-robot requested a review from LiorLieberman May 5, 2025 21:56

k8s-ci-robot requested a review from spencerhance May 5, 2025 22:03

LiorLieberman reviewed May 5, 2025

View reviewed changes

SinaChavoshi and others added 5 commits May 5, 2025 22:29

Fix missing containerPort, is missing

0455c47

change gateway name from "gateway-conformance-app" to "conformance-ga…

b531e66

…teway"

clarify why K8s types are needed.

5510e69

Update conformance/conformance.go

04c9798

Co-authored-by: Lior Lieberman <liorlib7+riskified@gmail.com>

Update conformance/conformance.go

9427f31

Co-authored-by: Lior Lieberman <liorlib7+riskified@gmail.com>

SinaChavoshi and others added 6 commits May 5, 2025 23:04

remove exessive logging

e3c8381

Update conformance/conformance.go

c9a8f77

Co-authored-by: Lior Lieberman <liorlib7+riskified@gmail.com>

move excess debug logs behind debug flag.

5ac19ff

remove CONFORMANCE.GO prefix from logs.

3b8df3b

change the pull logic and use default value from GatewayMustHaveAddress

bde61b8

fix mt.Sprintf can be replaced with string concatenation

57d68fd

LiorLieberman reviewed May 6, 2025

View reviewed changes

LiorLieberman approved these changes May 7, 2025

View reviewed changes

conformance/conformance.go Outdated Show resolved Hide resolved

conformance/conformance.go Outdated Show resolved Hide resolved

conformance/conformance.go Outdated Show resolved Hide resolved

conformance/utils/kubernetes/helpers.go Outdated Show resolved Hide resolved

SinaChavoshi added 4 commits May 7, 2025 17:21

add a function for logDebug

fa93b15

factor out ensureGatewayAvailableAndReady

06f29cc

removed todo comment in helper.go

da2e9ef

remove CONFORMANCE.GO from log

5e1d8e9

LiorLieberman approved these changes May 7, 2025

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2025

k8s-ci-robot assigned danehans May 7, 2025

SinaChavoshi mentioned this pull request May 8, 2025

chore(conformance): Add timeout configuration #795

Merged

danehans reviewed May 9, 2025

View reviewed changes

conformance/conformance.go Show resolved Hide resolved

conformance/conformance.go Outdated Show resolved Hide resolved

conformance/conformance.go Outdated Show resolved Hide resolved

error messages, should not be capitalized or end with punctuation

d8577b0

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2025

danehans reviewed May 9, 2025

View reviewed changes

conformance/utils/kubernetes/helpers.go Show resolved Hide resolved

conformance/conformance.go Show resolved Hide resolved

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2025

k8s-ci-robot merged commit 64a37d1 into kubernetes-sigs:main May 9, 2025
8 checks passed

zetxqx mentioned this pull request Jun 12, 2025

Conformance Tests for v0.5 Release #977

Closed

12 tasks

feat(conformance): Add initial InferencePool tests and shared Gateway setup #772

feat(conformance): Add initial InferencePool tests and shared Gateway setup #772

Uh oh!

Conversation

SinaChavoshi commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented May 1, 2025

Uh oh!

netlify bot commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for gateway-api-inference-extension ready!

Uh oh!

ahg-g commented May 4, 2025

Uh oh!

SinaChavoshi commented May 5, 2025

Uh oh!

LiorLieberman commented May 5, 2025

Uh oh!

LiorLieberman commented May 5, 2025

Uh oh!

spencerhance commented May 5, 2025

Uh oh!

LiorLieberman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LiorLieberman left a comment

Choose a reason for hiding this comment

Uh oh!

SinaChavoshi commented May 6, 2025

Uh oh!

LiorLieberman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LiorLieberman left a comment

Choose a reason for hiding this comment

Uh oh!

SinaChavoshi commented May 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

danehans left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

k8s-ci-robot commented May 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

SinaChavoshi commented May 1, 2025 •

edited

Loading

netlify bot commented May 1, 2025 •

edited

Loading