extract pod representation from backend/metrics to backend #751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfswain, nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
nirrozenbaum
force-pushed
the
extract-pod-def
branch
from
1adaa90 to
ea9e047
Compare
k8s-ci-robot
removed
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
elevran
pushed a commit
to epplib/gateway-api-inference-extension
that referenced
this pull request
Apr 30, 2025
…s-sigs#751) Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
rlakhtakia
pushed a commit
to rlakhtakia/gateway-api-inference-extension
that referenced
this pull request
Apr 30, 2025
…s-sigs#751) Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
kaushikmitr
pushed a commit
to kaushikmitr/llm-instance-gateway
that referenced
this pull request
May 15, 2025
…s-sigs#751) Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the Pod minimal representation from backend/metrics to backend.
I'm working on other PRs that implement scraper concept to allow extensibility for pod scraping.
for the use of this, it's useful to reuse the same pod definition.
since this change touches a lot of files that are using the pod definition, it makes sense to push it in a separate PR.