Skip to content

Conversation

terrytangyuan
Copy link
Member

This fixes the following issues when building the binary:

> go build -o /ext-proc
cache/cache.go:90:2: cacheKey declared and not used
./main.go:99:17: undefined: rest
./main.go:104:2: clientset declared and not used
./main.go:104:20: undefined: kubernetes

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 19, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 19, 2024
@kfswain
Copy link
Collaborator

kfswain commented Sep 19, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0598654 into main Sep 19, 2024
2 checks passed
@terrytangyuan terrytangyuan deleted the fix-build branch September 20, 2024 00:14
shaneutt pushed a commit to shaneutt/gateway-api-inference-extension that referenced this pull request Apr 18, 2025
- CONTAINER_TOOL setting commented out until can be fixed correctly (Ref kubernetes-sigs#7)
- image name was missing `epp` as last element in tag

Signed-off-by: Etai Lev Ran <elevran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants