Skip to content

Conversation

nirrozenbaum
Copy link
Contributor

@nirrozenbaum nirrozenbaum commented Mar 31, 2025

fix #620 (follow up PR to #485 (review))

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 31, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 31, 2025
Copy link

netlify bot commented Mar 31, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit caa3282
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67eae7229ba7110008a92037
😎 Deploy Preview https://deploy-preview-621--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nirrozenbaum
Copy link
Contributor Author

cc @danehans @ahg-g

@ahg-g
Copy link
Contributor

ahg-g commented Apr 6, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2c0a637 into kubernetes-sigs:main Apr 6, 2025
8 checks passed
@nirrozenbaum nirrozenbaum deleted the e2e branch April 7, 2025 03:26
kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request Apr 29, 2025
* added timeout to curl command which may otherwise hang

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>

* check HF_TOKEN set at the beginning of the test

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>

---------

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request Apr 29, 2025
* added timeout to curl command which may otherwise hang

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>

* check HF_TOKEN set at the beginning of the test

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>

---------

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request Apr 29, 2025
* added timeout to curl command which may otherwise hang

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>

* check HF_TOKEN set at the beginning of the test

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>

---------

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

few minor issues in e2e tests

3 participants