Skip to content

Conversation

ahg-g
Copy link
Contributor

@ahg-g ahg-g commented Mar 14, 2025

Fixes #419

This will allow us to create integration tests for the reconcilers in a followup PRs.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from Jeffwan March 14, 2025 21:35
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 14, 2025
@k8s-ci-robot k8s-ci-robot requested a review from liu-cong March 14, 2025 21:35
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 14, 2025
Copy link

netlify bot commented Mar 14, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit cfed5d2
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67d4a515180f1100081d618b
😎 Deploy Preview https://deploy-preview-505--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kfswain
Copy link
Collaborator

kfswain commented Mar 14, 2025

/lgtm

This is awesome! Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2025
@ahg-g ahg-g force-pushed the integration-fix branch from f93d972 to cfed5d2 Compare March 14, 2025 21:52
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2025
@kfswain
Copy link
Collaborator

kfswain commented Mar 14, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit 8fcc95f into kubernetes-sigs:main Mar 14, 2025
8 checks passed
kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integration tests should not create InferenceModel/InferencePool objects from a test yaml file

3 participants