Skip to content

Conversation

kfswain
Copy link
Collaborator

@kfswain kfswain commented Feb 10, 2025

Fixes #313

Have some dead links in our API, this PR resolves this

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 10, 2025
Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 527c05f
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67aa6e10fe963500081981e6
😎 Deploy Preview https://deploy-preview-314--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kfswain
Copy link
Collaborator Author

kfswain commented Feb 10, 2025

/hold

letting the CI deploy/netlify host a staging site to make sure the links are properly fixed.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2025
@robscott
Copy link
Member

Thanks @kfswain!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2025
@kfswain
Copy link
Collaborator Author

kfswain commented Feb 10, 2025

/unhold

they seem to be workin

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit d74eefa into kubernetes-sigs:main Feb 10, 2025
7 checks passed
@kfswain kfswain deleted the mkdocs-fixes branch February 10, 2025 22:56
kfswain added a commit to kfswain/llm-instance-gateway that referenced this pull request Apr 29, 2025
* Link to v0.1.0 getting started guide

* Moving getting started guide to the site

* site doesnt support markdown syntax for ordered lists, making explicit

* fiddling with mkdocs syntax

* mkdocs fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dead API link in public docs on API Overview

3 participants