-
Notifications
You must be signed in to change notification settings - Fork 180
use replicas field in helm to decide if EPP should run in HA mode #1628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use replicas field in helm to decide if EPP should run in HA mode #1628
Conversation
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I like this, and this is also extensible when we also supports active-active HA mode (such as adding a new |
/lgtm /hold to give others time to take a look. If we get this in today, I highly suggest we add it to the patch release #1616 |
I agree, this looks great! I think this aligns closely with the intent of: #1620 (comment) and create a more flexible config surface. Thanks Nir! |
/unhold |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
use a single field (replicas) in the helm chart to decide whether EPP should run in HA mode or not.
this change verifies replicas is still overridable, and also verifies helm cannot be used to set active active mode.
if one uses replicas with a value greater than 1, helm will set HA in active passive mode.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: