Skip to content

Conversation

nirrozenbaum
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
use a single field (replicas) in the helm chart to decide whether EPP should run in HA mode or not.
this change verifies replicas is still overridable, and also verifies helm cannot be used to set active active mode.
if one uses replicas with a value greater than 1, helm will set HA in active passive mode.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

None

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 21, 2025
Copy link

netlify bot commented Sep 21, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 97cfa24
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68cfb7cb87715e0008cbcd02
😎 Deploy Preview https://deploy-preview-1628--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2025
@nirrozenbaum
Copy link
Contributor Author

cc: @ahg-g @kfswain @liu-cong

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 21, 2025
@liu-cong
Copy link
Contributor

I like this, and this is also extensible when we also supports active-active HA mode (such as adding a new HAMode parameter).

@liu-cong
Copy link
Contributor

/lgtm

/hold to give others time to take a look. If we get this in today, I highly suggest we add it to the patch release #1616

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2025
@kfswain
Copy link
Collaborator

kfswain commented Sep 22, 2025

I agree, this looks great! I think this aligns closely with the intent of: #1620 (comment) and create a more flexible config surface. Thanks Nir!

@nirrozenbaum
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2025
@k8s-ci-robot k8s-ci-robot merged commit 6e6823a into kubernetes-sigs:main Sep 22, 2025
11 checks passed
kfswain pushed a commit that referenced this pull request Sep 23, 2025
)

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
@nirrozenbaum nirrozenbaum deleted the helm-leader-enabled branch September 25, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants