Skip to content

fix helm chart support for gke v1alpha2. #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2025
+9 −4
Merged

fix helm chart support for gke v1alpha2. #1551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/charts/inferencepool/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ The following table list the configurable parameters of the chart.

| **Parameter Name** | **Description** |
|---------------------------------------------|------------------------------------------------------------------------------------------------------------------------|
| `inferencePool.apiVersion` | The API version of the InferencePool resource. Defaults to `inference.networking.k8s.io/v1`. This can be changed to `inference.networking.x-k8s.io/v1alpha2` to support older API versions. |
| `inferencePool.targetPortNumber` | Target port number for the vllm backends, will be used to scrape metrics by the inference extension. Defaults to 8000. |
| `inferencePool.modelServerType` | Type of the model servers in the pool, valid options are [vllm, triton-tensorrt-llm], default is vllm. |
| `inferencePool.modelServers.matchLabels` | Label selector to match vllm backends managed by the inference pool. |
Expand Down
4 changes: 4 additions & 0 deletions config/charts/inferencepool/templates/epp-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ spec:
- {{ .Release.Name }}
- --pool-namespace
- {{ .Release.Namespace }}
{{- if ne .Values.inferencePool.apiVersion "inference.networking.k8s.io" }}
- --pool-group
- "{{ (split "/" .Values.inferencePool.apiVersion)._0 }}"
{{- end }}
- --zap-encoder
- "json"
- --config-file
Expand Down
4 changes: 2 additions & 2 deletions config/charts/inferencepool/templates/gke.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ metadata:
{{- include "gateway-api-inference-extension.labels" . | nindent 4 }}
spec:
targetRef:
group: "inference.networking.k8s.io"
group: "{{ (split "/" .Values.inferencePool.apiVersion)._0 }}"
kind: InferencePool
name: {{ .Release.Name }}
default:
Expand All @@ -28,7 +28,7 @@ metadata:
{{- include "gateway-api-inference-extension.labels" . | nindent 4 }}
spec:
targetRef:
group: "inference.networking.k8s.io"
group: "{{ (split "/" .Values.inferencePool.apiVersion)._0 }}"
kind: InferencePool
name: {{ .Release.Name }}
default:
Expand Down
4 changes: 2 additions & 2 deletions config/charts/inferencepool/templates/rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ metadata:
{{- include "gateway-api-inference-extension.labels" . | nindent 4 }}
rules:
- apiGroups: ["inference.networking.x-k8s.io"]
resources: ["inferenceobjectives", "inferencepools"]
resources: ["inferenceobjectives"]
verbs: ["get", "watch", "list"]
- apiGroups: ["inference.networking.k8s.io"]
- apiGroups: ["{{ (split "/" .Values.inferencePool.apiVersion)._0 }}"]
resources: ["inferencepools"]
verbs: ["get", "watch", "list"]
- apiGroups: [""]
Expand Down