-
Notifications
You must be signed in to change notification settings - Fork 179
Make apiVersion configurable for inferencePool in the helm charts #1542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hi @rahulgurnani. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Tested:
|
0f6ca61
to
a655bda
Compare
@rahulgurnani thanks for the quick PR. v1 has targetPorts: number while v1alpha2 has targetPortNumber. do you mind comparing inf pool template from v0.5.1 (in the release 0.5 branch) to latest to make sure we don’t miss anything? |
/ok-to-test |
Also, the v1alpha1 inferencepool api is in the x-k8s.io group. So I'm not sure that this will successfully apply as is. |
Sure @nirrozenbaum , I updated the PR to accommodate for this, PTAL. The current output:
|
Is this output from a helm dry run? Do you mind actually applying it to a cluster that had both versions of the CRD installed? Helm doesn't do any validation against CRD definitions |
/retest |
71903ab
to
4ebab20
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nirrozenbaum, rahulgurnani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1541
Does this PR introduce a user-facing change?:
cc @nirrozenbaum