Skip to content

Conversation

rahulgurnani
Copy link
Contributor

@rahulgurnani rahulgurnani commented Sep 5, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1541

Does this PR introduce a user-facing change?:


cc @nirrozenbaum

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 5, 2025
Copy link

netlify bot commented Sep 5, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 4ebab20
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68bcaca4cd854e00083d3524
😎 Deploy Preview https://deploy-preview-1542--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 5, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 5, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @rahulgurnani. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 5, 2025
@rahulgurnani
Copy link
Contributor Author

Tested:

rahulgurnani@rahulgurnani3:~/gateway-api-inference-extension/config/charts/inferencepool$ helm template .  --debug --set  inferencePool.apiVersion=inference.networking.k8s.io/v1alpha1
install.go:225: 2025-09-05 19:45:49.147211813 +0000 UTC m=+0.062051816 [debug] Original chart version: ""
install.go:242: 2025-09-05 19:45:49.147334015 +0000 UTC m=+0.062173996 [debug] CHART PATH: /usr/local/google/home/rahulgurnani/gateway-api-inference-extension/config/charts/inferencepool

---
...
---
# Source: inferencepool/templates/inferencepool.yaml
apiVersion: inference.networking.k8s.io/v1alpha1
kind: InferencePool
metadata:
  name: release-name
  namespace: default
  labels:
    app.kubernetes.io/name: release-name-epp
    app.kubernetes.io/version: "0.0.0"
spec:
  targetPorts:
      - number: 8000
  selector:
    matchLabels:
      app: "vllm-llama3-8b-instruct"
  endpointPickerRef:
    name: release-name-epp
    port:
      number: 9002

@nirrozenbaum
Copy link
Contributor

nirrozenbaum commented Sep 5, 2025

@rahulgurnani thanks for the quick PR.
however I think it’s a bit trickier than current fix.
the thing is that v1 crd and v1alpha2 crd have few different fields, which are used for the same purpose.

v1 has targetPorts: number while v1alpha2 has targetPortNumber.

do you mind comparing inf pool template from v0.5.1 (in the release 0.5 branch) to latest to make sure we don’t miss anything?

@nirrozenbaum
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 5, 2025
@kfswain
Copy link
Collaborator

kfswain commented Sep 5, 2025

@rahulgurnani thanks for the quick PR.

however I think it’s a bit trickier than current fix.

the thing is that v1 crd and v1alpha2 crd have few different fields, which are used for the same purpose.

v1 has targetPorts: number while v1alpha2 has targetPortNumber.

do you mind comparing inf pool template from v0.5.1 (in the release 0.5 branch) to latest to make sure we don’t miss anything?

Also, the v1alpha1 inferencepool api is in the x-k8s.io group. So I'm not sure that this will successfully apply as is.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 6, 2025
@rahulgurnani
Copy link
Contributor Author

rahulgurnani commented Sep 6, 2025

@rahulgurnani thanks for the quick PR. however I think it’s a bit trickier than current fix. the thing is that v1 crd and v1alpha2 crd have few different fields, which are used for the same purpose.

v1 has targetPorts: number while v1alpha2 has targetPortNumber.

do you mind comparing inf pool template from v0.5.1 (in the release 0.5 branch) to latest to make sure we don’t miss anything?

Sure @nirrozenbaum , I updated the PR to accommodate for this, PTAL.

The current output:

$~/gateway-api-inference-extension/config/charts/inferencepool$ helm template .  --debug --set  inferencePool.apiVersion=inference.networking.x-k8s.io/v1alpha2
...
---
# Source: inferencepool/templates/inferencepool.yaml
apiVersion: inference.networking.x-k8s.io/v1alpha2
kind: InferencePool
metadata:
  name: release-name
  namespace: default
  labels:
    app.kubernetes.io/name: release-name-epp
    app.kubernetes.io/version: "0.0.0"
spec:
  
  targetPortNumber:
      - number: 8000
  
  selector:
    matchLabels:
      app: "vllm-llama3-8b-instruct"
  endpointPickerRef:
    name: release-name-epp
    port:
      number: 9002

@kfswain
Copy link
Collaborator

kfswain commented Sep 6, 2025

Is this output from a helm dry run?

Do you mind actually applying it to a cluster that had both versions of the CRD installed?

Helm doesn't do any validation against CRD definitions

@kfswain
Copy link
Collaborator

kfswain commented Sep 6, 2025

/retest

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 6, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 6, 2025
@nirrozenbaum
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirrozenbaum, rahulgurnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit 8b154ba into kubernetes-sigs:main Sep 7, 2025
10 checks passed
nirrozenbaum pushed a commit that referenced this pull request Sep 7, 2025
)

* Make apiVersion configurable in helm chart for inferencePool

* Update helm chart to accomodate for targetPortNumber in v1alpha2

* updating helm charts to work on the cluster with v1 and v1a2

---------

Co-authored-by: Kellen Swain <kfswain@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm chart always installs inferencepool from group v1
4 participants