Skip to content

cleanup modelName from inferenceObjective. #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2025
+0 −24
Merged

cleanup modelName from inferenceObjective. #1521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions apix/v1alpha2/inferenceobjective_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import (
// +kubebuilder:object:root=true
// +kubebuilder:subresource:status
// +kubebuilder:storageversion
// +kubebuilder:printcolumn:name="Model Name",type=string,JSONPath=`.spec.modelName`
// +kubebuilder:printcolumn:name="Inference Pool",type=string,JSONPath=`.spec.poolRef.name`
// +kubebuilder:printcolumn:name="Priority",type=string,JSONPath=`.spec.priority`
// +kubebuilder:printcolumn:name="Age",type=date,JSONPath=`.metadata.creationTimestamp`
Expand Down Expand Up @@ -56,12 +55,6 @@ type InferenceObjectiveList struct {
// performance and latency goals for the model. These workloads are
// expected to operate within an InferencePool sharing compute capacity with other
// InferenceObjectives, defined by the Inference Platform Admin.
//
// InferenceObjective's modelName (not the ObjectMeta name) is unique for a given InferencePool,
// if the name is reused, an error will be shown on the status of a
// InferenceObjective that attempted to reuse. The oldest InferenceObjective, based on
// creation timestamp, will be selected to remain valid. In the event of a race
// condition, one will be selected at random.
type InferenceObjectiveSpec struct {

// Priority defines how important it is to serve the request compared to other requests in the same pool.
Expand Down Expand Up @@ -135,10 +128,6 @@ const (
//
// * "Accepted"
//
// Possible reasons for this condition to be False are:
//
// * "ModelNameInUse"
//
// Possible reasons for this condition to be Unknown are:
//
// * "Pending"
Expand All @@ -148,10 +137,6 @@ const (
// ObjectiveReasonAccepted is the desired state. Model conforms to the state of the pool.
ObjectiveReasonAccepted InferenceObjectiveConditionReason = "Accepted"

// ObjectiveReasonNameInUse is used when a given ModelName already exists within the pool.
// Details about naming conflict resolution are on the ModelName field itself.
ObjectiveReasonNameInUse InferenceObjectiveConditionReason = "ModelNameInUse"

// ObjectiveReasonPending is the initial state, and indicates that the controller has not yet reconciled the InferenceObjective.
ObjectiveReasonPending InferenceObjectiveConditionReason = "Pending"
)
9 changes: 0 additions & 9 deletions config/crd/bases/inference.networking.x-k8s.io_inferenceobjectives.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ spec:
scope: Namespaced
versions:
- additionalPrinterColumns:
- jsonPath: .spec.modelName
name: Model Name
type: string
- jsonPath: .spec.poolRef.name
name: Inference Pool
type: string
Expand Down Expand Up @@ -61,12 +58,6 @@ spec:
performance and latency goals for the model. These workloads are
expected to operate within an InferencePool sharing compute capacity with other
InferenceObjectives, defined by the Inference Platform Admin.

InferenceObjective's modelName (not the ObjectMeta name) is unique for a given InferencePool,
if the name is reused, an error will be shown on the status of a
InferenceObjective that attempted to reuse. The oldest InferenceObjective, based on
creation timestamp, will be selected to remain valid. In the event of a race
condition, one will be selected at random.
properties:
poolRef:
description: PoolRef is a reference to the inference pool, the pool
Expand Down