test: Refactor end to end test code to enable reuse downstream #1515
Conversation
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
|
@shmuelk: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @shmuelk. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/XL
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/retest |
|
/assign @rahulgurnani Since you are planning to refactor the e2e tests to use the helm charts, Rahul can you take a stab at reviewing this related PR? |
|
@ahg-g: GitHub didn't allow me to assign the following users: rahulgurnani. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| return objNames | ||
| } | ||
|
|
||
| func DeleteObjects(testConfig *TestConfig, kindAndNames []string) { |
There was a problem hiding this comment.
Please add a comment for the exported method
| defaultInterval = time.Millisecond * 250 | ||
| ) | ||
|
|
||
| type TestConfig struct { |
There was a problem hiding this comment.
Please add a comment for the exported type.
| } | ||
| } | ||
|
|
||
| func (testConfig *TestConfig) CreateCli() { |
There was a problem hiding this comment.
please add comment for exported method
|
Thanks for sending this change out. Added some minor comments, looks good otherwise. |
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, shmuelk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
5 participants
What type of PR is this?
/kind test
What this PR does / why we need it:
This PR takes several private helper functions in the EPP End to End tests and makes them public in the test/utils package.
This enables the reuse of these helper functions in other tests as well as in End to End tests of the downstream llm-d-inference-scheduler.
Some improvements were also made to some of the helper functions to help minimize the amount of code in the tests.
Does this PR introduce a user-facing change?: