-
Notifications
You must be signed in to change notification settings - Fork 180
Pluggable data layer: transition backend/metrics
to use type aliases from datalayer
package
#1351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pluggable data layer: transition backend/metrics
to use type aliases from datalayer
package
#1351
Conversation
Signed-off-by: Etai Lev Ran <elevran@gmail.com>
Signed-off-by: Etai Lev Ran <elevran@gmail.com>
Signed-off-by: Etai Lev Ran <elevran@gmail.com>
Signed-off-by: Etai Lev Ran <elevran@gmail.com>
Signed-off-by: Etai Lev Ran <elevran@gmail.com>
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
backend/metrics
to use type aliases from datalayer
package
/lgtm Thanks |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, elevran The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR introduces several interfaces and wrappers to allow users of
backend/metrics
code to work withdatalayer
as an implementation.backend
andmetrics
(e.g.,MetricsState
,PodMetrics
,Pod
) as aliases to corresponding types indatalayer
datastore
) from the concrete implementations ofbackend/metrics
.For example,
EndpointFactory
interface variable in datastore instead of a concretePodMetricsFactory
struct.podMetrics
so it implements the expected extended attribute interface (another option is to define Endpoint without it and type assert fromEndpoint
to (e.g.,)EndpointWithExtendedAttributes
inside the datalayer).RefreshLoop
handling is now delegated to theEndpointFactory
which allows removingStopRefreshLoop
from the public interface (the factory was already calling the privatestartRefreshLoop
method).In terms of next steps to complete the co-existence:
EXPERIMENTAL_DATALAYER_V2
set for datalayer package based implementation).