Skip to content

fix: updated to v1 inferencepool in manifests #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 29, 2025
Merged

fix: updated to v1 inferencepool in manifests #1248

merged 3 commits into from
Jul 29, 2025

Conversation

capri-xiyue
Copy link
Contributor

updated to v1 inferencepool in manifests

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 28, 2025
@netlify Netlify
Copy link

netlify bot commented Jul 28, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 1c91673
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68880936b6ab650008de249c
😎 Deploy Preview https://deploy-preview-1248--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 28, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @capri-xiyue. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 28, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and liu-cong July 28, 2025 22:23
@capri-xiyue
Copy link
Contributor Author

/assign @kfswain

@kfswain
Copy link
Collaborator

kfswain commented Jul 28, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 28, 2025
@capri-xiyue
Copy link
Contributor Author

/assign @kfswain

@kfswain
Copy link
Collaborator

kfswain commented Jul 28, 2025

/approve

This looks good to me. I see KGateway & Istio changes.

Will CC: @danehans & @LiorLieberman to take a quick look and give the lgtm to make sure this isnt going to break them

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: capri-xiyue, kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2025
@capri-xiyue
Copy link
Contributor Author

/approve

This looks good to me. I see KGateway & Istio changes.

Will CC: @danehans & @LiorLieberman to take a quick look and give the lgtm to make sure this isnt going to break them

Talked with @danehans kgateway doesn't support v1 InferencePool yet. Will keep kgateway to alpha InferencePool

@capri-xiyue
Copy link
Contributor Author

/approve

This looks good to me. I see KGateway & Istio changes.

Will CC: @danehans & @LiorLieberman to take a quick look and give the lgtm to make sure this isnt going to break them

For istio, istio/istio#57099 seems like it doesn't support v1 InferencePool. I will leave it to alpha now.

@kfswain
Copy link
Collaborator

kfswain commented Jul 28, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2025
@capri-xiyue
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit fa5fc16 into kubernetes-sigs:main Jul 29, 2025
9 checks passed
kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request Jul 31, 2025
@capri-xiyue @kfswain
fix: updated to v1 inferencepool in manifests (kubernetes-sigs#1248)
5ae2512 
* updated to v1 inferencepool

* leave kgateway to alpha inferencepool

* move istio to alpha inferencepool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g Awaiting requested review from ahg-g

@liu-cong liu-cong Awaiting requested review from liu-cong

Assignees

@kfswain kfswain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@capri-xiyue @k8s-ci-robot @kfswain