Skip to content

Conversation

nirrozenbaum
Copy link
Contributor

This PR adds logging of the scheduler config on bootstrap, using String() function on SchedulerConfig and SchedulerProfile.
before this change, there was a log line setupLog.Info("Configuration file loaded", "config", config) that was logging nothing, the output in the log was something like &EndpointPickerConfig{}.

After this change, it's very clear what is the scheduler config that is being used.
Tested this change for both canned configurations.
output of default-plugins.yaml:

{"level":"info","ts":"2025-07-28T17:58:58Z","logger":"setup","caller":"runner/runner.go:321","msg":"parsed 
config","scheduler-config":"{ProfileHandler: single-profile-handler/single-profile-handler, Profiles: map[default:{Filters: [low-
queue-filter/low-queue-filter], Scorers: [], Picker: random-picker/random-picker, PostCyclePlugins: []}]}"}

output of plugins-v2.yaml:

{"level":"info","ts":"2025-07-28T17:49:58Z","logger":"setup","caller":"runner/runner.go:321","msg":"parsed 
config","scheduler-config":"{ProfileHandler: single-profile-handler/single-profile-handler, Profiles: map[default:{Filters: [], 
Scorers: [queue-scorer/queue-scorer: 1, kv-cache-scorer/kv-cache-scorer: 1, prefix-cache-scorer/prefix-cache-scorer: 1], 
Picker: max-score-picker/max-score-picker, PostCyclePlugins: [prefix-cache-scorer/prefix-cache-scorer]}]}"}

cc: @ahg-g @shmuelk @kfswain @elevran

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

netlify bot commented Jul 28, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit b2ce0a4
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6887c44bb76e1500080539c4
😎 Deploy Preview https://deploy-preview-1247--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 28, 2025
@nirrozenbaum
Copy link
Contributor Author

just as a clarification, when you see a plugin logged the format is of TypedName, that is <Name>/<Type>.
in the canned configurations no names are specified so all names are defaulted to the corresponding types.

@kfswain
Copy link
Collaborator

kfswain commented Jul 28, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit a81214f into kubernetes-sigs:main Jul 28, 2025
9 checks passed
@nirrozenbaum nirrozenbaum deleted the config-log branch July 28, 2025 19:57
Copy link
Contributor

@kfirtoledo kfirtoledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request Jul 31, 2025
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants