Skip to content

Conversation

kaushikmitr
Copy link
Contributor

This pull request updates the regression testing documentation to enhance clarity, improve formatting, and introduce a new section on nightly benchmarking. The most important changes include reformatting test case descriptions, adding details about traffic distribution and metrics expectations, and documenting the nightly benchmarking process.

Documentation Improvements:

  • Reformatted Test Case Details: Improved readability for test cases by using clearer formatting, such as bullet points and percentages for traffic distribution in the multi-LoRA test case. Updated terminology for request rates (QPS) and added clarity to dataset descriptions.
  • Enhanced Metrics Expectations: Clarified expectations for regression analysis metrics, including R² values for prompts and latency, with minor variance allowances.

New Nightly Benchmarking Section:

  • Nightly Benchmarking Pipeline: Added a detailed description of the automated nightly benchmarking process, including datasets used, benchmarking steps, and alerting mechanisms for regression detection.

Copy link

netlify bot commented Jul 25, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit e208c66
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/688406ec9b257c0008e5d4c2
😎 Deploy Preview https://deploy-preview-1234--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 25, 2025
@k8s-ci-robot k8s-ci-robot requested review from danehans and kfswain July 25, 2025 21:05
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 25, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @kaushikmitr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 25, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Jul 25, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 25, 2025
@kfswain
Copy link
Collaborator

kfswain commented Jul 29, 2025

Looks great! Thanks for all the work here, this is hugely beneficial.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaushikmitr, kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2025
@kaushikmitr
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit f33ff43 into kubernetes-sigs:main Jul 29, 2025
8 checks passed
kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request Jul 31, 2025
* add nightly benchmarking documentation

* move nightly benchmarking documentation to the end of index.md

* update regression testing index.md

* update regression testing index.md

* update regression testing index.md

* update regression testing index.md

* update regression testing index.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants