Skip to content

Conversation

sats-23
Copy link
Contributor

@sats-23 sats-23 commented Jul 23, 2025

Fixes #1210

There has been only one instance of TODO in the website, removing the same.

Copy link

netlify bot commented Jul 23, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit a4c246a
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68807a5867601300081ffe4b
😎 Deploy Preview https://deploy-preview-1221--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 23, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and robscott July 23, 2025 05:42
@k8s-ci-robot
Copy link
Contributor

Welcome @sats-23!

It looks like this is your first PR to kubernetes-sigs/gateway-api-inference-extension 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api-inference-extension has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 23, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @sats-23. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 23, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Jul 23, 2025

/ok-to-test

Are we not planning to add a dev guide anymore? What about the guide to add new plugins? @elevran @nirrozenbaum @kfswain

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 23, 2025
@nirrozenbaum
Copy link
Contributor

/ok-to-test

Are we not planning to add a dev guide anymore? What about the guide to add new plugins? @elevran @nirrozenbaum @kfswain

yes. we plan to add guide for new plugins.
having said that, I'm in favor of removing TODOs pages and add only when the information is added.
I prefer to avoid placeholders.

@ahg-g
Copy link
Contributor

ahg-g commented Jul 23, 2025

sgtm

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, sats-23

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2025
@kfswain
Copy link
Collaborator

kfswain commented Jul 23, 2025

I prefer to avoid placeholders.

Agreed. And with GA rapidly coming, I would rather get rid of dangling pages and then add guides.

WRT dev guide, we have our contribution section on the top level readme as a loose entry point, and then I think plugin guides would be very powerful also. Those issues are cut, but lower prio.

@k8s-ci-robot k8s-ci-robot merged commit 9dacc6c into kubernetes-sigs:main Jul 23, 2025
9 checks passed
@elevran
Copy link
Contributor

elevran commented Jul 23, 2025

WRT dev guide, we have our contribution section on the top level readme as a loose entry point, and then I think plugin guides would be very powerful also. Those issues are cut, but lower prio.

Just for awareness, we do have a minimal guide in llm-d schedule and it can be extended (llm-d/llm-d-inference-scheduler#114).
We could move that over (though it should move with the accompanying files as it is a real filter that's used).

kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrub the site of any TODO stubs
6 participants