-
Notifications
You must be signed in to change notification settings - Fork 179
Remove TODO stubs from website #1221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Welcome @sats-23! |
Hi @sats-23. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test Are we not planning to add a dev guide anymore? What about the guide to add new plugins? @elevran @nirrozenbaum @kfswain |
yes. we plan to add guide for new plugins. |
sgtm /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, sats-23 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Agreed. And with GA rapidly coming, I would rather get rid of dangling pages and then add guides. WRT dev guide, we have our contribution section on the top level readme as a loose entry point, and then I think plugin guides would be very powerful also. Those issues are cut, but lower prio. |
Just for awareness, we do have a minimal guide in llm-d schedule and it can be extended (llm-d/llm-d-inference-scheduler#114). |
Fixes #1210
There has been only one instance of TODO in the website, removing the same.