Skip to content

Conversation

yafengio
Copy link
Contributor

The current package import is rather disordered.

Imports are organized in groups, with blank lines between them. The standard library packages are always in the first group.

See: https://go.dev/wiki/CodeReviewComments#imports

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 23, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @yafengio. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 23, 2025
Copy link

netlify bot commented Jul 23, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 51b8aab
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6880696b57742800089df2a6
😎 Deploy Preview https://deploy-preview-1220--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nirrozenbaum
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 23, 2025
@yafengio
Copy link
Contributor Author

/retest

@ahg-g
Copy link
Contributor

ahg-g commented Jul 23, 2025

This is nice, do you have a tool for that? or did you do it manually?

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, yafengio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2025
@k8s-ci-robot k8s-ci-robot merged commit f01a605 into kubernetes-sigs:main Jul 23, 2025
9 checks passed
@yafengio
Copy link
Contributor Author

This is nice, do you have a tool for that? or did you do it manually?

/lgtm /approve

Yes, there is a tool that can achieve it. I've submitted a PR . Please review it. Thx #1228

kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request Jul 31, 2025
* style: ✨ optimize import order and more readable.

* fix: 🐛 goimports check failed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants