-
Notifications
You must be signed in to change notification settings - Fork 180
style: ✨ optimize import order and more readable. #1220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: ✨ optimize import order and more readable. #1220
Conversation
Hi @yafengio. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
/ok-to-test |
/retest |
This is nice, do you have a tool for that? or did you do it manually? /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, yafengio The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yes, there is a tool that can achieve it. I've submitted a PR . Please review it. Thx #1228 |
* style: ✨ optimize import order and more readable. * fix: 🐛 goimports check failed.
The current package import is rather disordered.
Imports are organized in groups, with blank lines between them. The standard library packages are always in the first group.
See: https://go.dev/wiki/CodeReviewComments#imports