refactor(flowcontrol): Enable behavioral mocking #1202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @LukeAVanDrie. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/L
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/lgtm Testing infra for flow control |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, LukeAVanDrie The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
The existing mock implementations for the flow control framework policies and accessors were simple stubs that returned fixed values. This style of mocking is too restrictive for testing complex, concurrent components where behavior needs to be dynamically controlled at test time. To prepare for testing more advanced orchestration logic, this commit refactors the core mocks to use function fields instead of static return values. This transforms them from simple stubs into flexible, behavioral mocks. Tests can now inject custom logic at runtime to simulate a wide range of policy decisions and interactions. The following mocks were updated: - MockPriorityBandAccessor - MockIntraFlowDispatchPolicy - MockInterFlowDispatchPolicy The policy tests that consume these mocks have been updated to use this new, more powerful mocking pattern.
LukeAVanDrie
force-pushed
the
refactor/flow-control-mocks
branch
from
a307ff0 to
3356cad
Compare
k8s-ci-robot
added
size/XL
|
/lgtm |
k8s-ci-robot
added
the
lgtm
kfswain
pushed a commit
to kfswain/llm-instance-gateway
that referenced
this pull request
Jul 31, 2025
The existing mock implementations for the flow control framework policies and accessors were simple stubs that returned fixed values. This style of mocking is too restrictive for testing complex, concurrent components where behavior needs to be dynamically controlled at test time. To prepare for testing more advanced orchestration logic, this commit refactors the core mocks to use function fields instead of static return values. This transforms them from simple stubs into flexible, behavioral mocks. Tests can now inject custom logic at runtime to simulate a wide range of policy decisions and interactions. The following mocks were updated: - MockPriorityBandAccessor - MockIntraFlowDispatchPolicy - MockInterFlowDispatchPolicy The policy tests that consume these mocks have been updated to use this new, more powerful mocking pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing mock implementations for the flow control framework policies and accessors were simple stubs that returned fixed values. This style of mocking is too restrictive for testing complex, concurrent components where behavior needs to be dynamically controlled at test time.
This tracks #674
To prepare for testing more advanced orchestration logic (in the subsequent PR), this commit refactors the core mocks to use function fields instead of static return values. This transforms them from simple stubs into flexible, behavioral mocks. Tests can now inject custom logic at runtime to simulate a wide range of policy decisions and interactions.
The following mocks were updated:
The policy tests that consume these mocks have been updated to use this new, more powerful mocking pattern.