Skip to content

Conversation

nirrozenbaum
Copy link
Contributor

@nirrozenbaum nirrozenbaum commented Jul 21, 2025

while working on release v0.5 I noticed the tags are Unverified.
when following the release issue, there are some commands that include that -s for signoff (in the commit section).
added the -s for the tag section to have verified tags.

cc @kfswain @danehans

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
Copy link

netlify bot commented Jul 21, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit c6c5269
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/687e82d4e2159c000831bf92
😎 Deploy Preview https://deploy-preview-1196--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 21, 2025
@k8s-ci-robot k8s-ci-robot requested review from danehans and kfswain July 21, 2025 18:11
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 21, 2025
@nirrozenbaum nirrozenbaum changed the title updated the tag command to inclue the -s for signing the tag release issue template: updated the tag command to include the -s for signing the tag Jul 21, 2025
@kfswain
Copy link
Collaborator

kfswain commented Jul 23, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1c51047 into kubernetes-sigs:main Jul 24, 2025
8 checks passed
@nirrozenbaum nirrozenbaum deleted the release-tag branch July 24, 2025 06:05
kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants