-
Notifications
You must be signed in to change notification settings - Fork 179
Fix a regression in prefix plugin which can cause data race #1188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
/lgtm Totally unrelated to the fix I do wonder if we should make the |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfswain, liu-cong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
why not using k8s set which encapsulates the map behind it? definitely more readable. see example:
gateway-api-inference-extension/pkg/epp/common/config/loader/configloader.go Lines 106 to 109 in 7182f8f
|
The code returns an internal
podSet
map which can be modified in a separate request goroutines. The fix is to return a deep copy of the map.This regression was introduced in a recent refactor.