-
Notifications
You must be signed in to change notification settings - Fork 180
initial update to load plugins from file #1151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial update to load plugins from file #1151
Conversation
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see the runner.go file getting lighter!
How did we test that the config file is generating the same hard coded configuration?
@ahg-g I tested it manually, both options default + v2, and added some logging to this PR to validate that. |
plugins: | ||
- pluginRef: low-latency-filter | ||
- pluginRef: random-picker | ||
scheduler-v2.yaml: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably useful to use some prefix indicating that this will be removed, perhaps experimental-with-prefix-cache-scorer.yaml
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scheduler-v2 will not be removed, the default will be removed.
v2 will become the new default.
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
/lgtm |
This PR adds plugins configuration loading from file and is starting to handle some cleanup.
There are still follow up PRs that are needed to complete cleanup, but main path in cmd/runner and in e2e tests is complete.
additional minor changes were done to update some of the plugin names for readability purpose. for example random picker plugin name was called
random
, update torandom-picker
since it's not possible to understand what does pluginrandom
means (same update was done to almost all plugins).out of this PR and handled in follow up PRs to keep each PR scoped and relatively small and focused:
scheduler.go
. this includes updates in several places like integration tests and scheduler unit-test and may be a big PR on its own. therefore left this point to a separate PR which will be tightly scoped for this purpose - done in remove NewScheduler function #1153.after the above is done, we should make sure any additional env var loading, helper functions or variables that were used to initialize plugins config are all removed. none of those should exist in code anymore.
cc: @ahg-g @kfswain @elevran @shmuelk